Show edit and export on small screens #4839
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into making the edit button visible on small screen #2233 and ran into a few issues that are making this less straight forward than I was hoping it to be.
btn-group-vertical
is a dropdown twbs/bootstrap#40487 and my PR button-group: Fixbtn-group-vertical
by using same rules asbtn-group
twbs/bootstrap#40488 might fix it.This is what it looks like:
Logged out:
Logged in:
Where do go from here?
I consider hiding the Edit button in 2024 a bug which we should fix. And this PR is a way to do this.
In the near future we will need to reconsider this part of the menu, especially the screen usually visible on mobile to incorporate editors in the menu (openstreetmap/operations#877 (comment)).
Open issues:
I can fix since depending on the feedback on this PR.
Closes #2233