Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust vertical alignment of secondary header navigation #4828

Merged
merged 3 commits into from
May 27, 2024

Conversation

AntonKhorev
Copy link
Collaborator

Like #4723 + adjustments inside the user button + increased horizontal spacing between menu items (in #4723 the spacing decreased because with display: flex whitespace between items gets removed).

I get rid of h1, nav, nav > ul, nav > ul > li selector and do other changes in order to switch later to Bootstrap navbar and decrease the number of menu/sidebar visibility modes.

Before / after when not logged in:
image
image

Before / after with issues counter:
image
image

Before / after with message counter:
image
image

@AntonKhorev AntonKhorev marked this pull request as draft May 24, 2024 17:44
@AntonKhorev AntonKhorev force-pushed the flex-secondary-header-nav branch from 1ad8600 to 868838b Compare May 24, 2024 17:54
@AntonKhorev AntonKhorev marked this pull request as ready for review May 24, 2024 17:55
@tomhughes
Copy link
Member

Looks like a nice improvement to me. Thanks.

@tomhughes tomhughes merged commit 2c90432 into openstreetmap:master May 27, 2024
20 checks passed
@AntonKhorev AntonKhorev deleted the flex-secondary-header-nav branch May 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants