Dim map tiles in dark mode #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
dark-mode-map-background
branch
from
afb2cbe to
ebb9937
Compare
|
This looks reasonable to me... I'm no expert on dark mode but the tiles are every bright without this and much more reasonable with it though I did have to turn my laptop brightness up a bit but I suspect that's just something I would have to do if I used dark mode as I normally keep it quite low. |
You left out the third option of not changing anything! Just leaving my two cents here to say this should be reverted. Thanks. |
|
Why dim the entire map? This makes things very difficult to read... Maybe a toggle to dim the map would be more appropriate. (As well as a toggle for dark mode in general) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map tiles are going to be too bright in dark mode. The question is then what to do with them. There are two options: dim them or invert them, and the existing dark themes like this one may offer a choice.
Here I'm making a conservative choice of 80% dimming.