Add Messages API

[milan-cvetkovic]

...as discussed in Proposal for Messages API - Issue #4509 and documented in Messaging API reference

[tordans]

I don't know enough about he code but it looks like this likely duplicates some logic. Can this be shared in a concern or something similar?

[milan-cvetkovic]

@tomhughes Friendly ping, any chance of reviewing the PR?

[tomhughes]

I've had a first pass over the code and an initial peek at the tests and added my comments. I'll definitely want @gravitystorm to have a look as well before we merge.

[tomhughes]

Has this been copied from notes and not removed?

[tomhughes]

This still seems to be present? What was the resolution?

[milan-cvetkovic]

Sorry, I guess there were 2 mentions of notes, and I only removed one.

[milan-cvetkovic]

I've had a first pass over the code and an initial peek at the tests and added my comments. I'll definitely want @gravitystorm to have a look as well before we merge.

Thanks for the review, will look into your comments shortly

[milan-cvetkovic]

Rebased and updated based on #4858.

[milan-cvetkovic]

@tomhughes Please advise if any modifications are required for this PR, thanks.

[tomhughes]

This still seems to be present? What was the resolution?

[tomhughes]

A few more minor comments...

[simonpoole]

A comment on the generated output of the new API

"version": "0.6",
    "generator": "OpenStreetMap server",
    "copyright": "OpenStreetMap and contributors",
    "attribution": "http://www.openstreetmap.org/copyright",
    "license": "http://opendatacommons.org/licenses/odbl/1-0/",
...

I don't believe we would want to make a statement on the copyright of the messages in the first place (because they are essentially private and in any scenario you would need to agree with whoever you had communicated with on publishing them), but if it would be anything, the copyright would be held by the individual author of the respective e-mail.

[milan-cvetkovic]

A comment on the generated output of the new API

"version": "0.6",
    "generator": "OpenStreetMap server",
    "copyright": "OpenStreetMap and contributors",
    "attribution": "http://www.openstreetmap.org/copyright",
    "license": "http://opendatacommons.org/licenses/odbl/1-0/",
...

I don't believe we would want to make a statement on the copyright of the messages in the first place (because they are essentially private and in any scenario you would need to agree with whoever you had communicated with on publishing them), but if it would be anything, the copyright would be held by the individual author of the respective e-mail.

This comes from including root_attributes in json and xml templates. I probably have it as a result of copying from other templates. However, it is not clear to me if we should include those headers in messages - your comment seems reasonable.

Side note - looking at notes (where I probably copied at least some templates from) I noticed that XML output does include the copyright notice, while json does not.

[milan-cvetkovic]

@tomhughes I updated the code according to your suggestions from the last review.

Please advise if more modifications are necessary.

[milan-cvetkovic]

@tomhughes code updated for comments from July 28.

[tomhughes]

Thanks. I think this all looks good now!