Display changeset element pagination vertically #4567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
vertical-sidebar-pagination
branch
from
eec6886 to
1d3a3c5
Compare
AntonKhorev
force-pushed
the
vertical-sidebar-pagination
branch
from
1d3a3c5 to
858d057
Compare
|
Probably looks too weird and may not work well with something like #5355 where I don't want to spend extra horizontal space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using #4563 without full sidebar reload, pagination links moving around becomes more annoying. It happens because sometimes they fit to the right of the "Nodes (...)" heading and sometimes they don't. We have more vertical space available and can "rotate" the links to distribute them along the right edge of the sidebar. In this case they'll always fit to the right of the heading and the element list.
Includes first commits of #4563 with refactoring.