Add "view" tab to main navigation #2420
Conversation
Added a "View" tab to the primary nav. Uses layouts.view for link name.
Added "layouts.view" for the primary nav "view" tab.
Add support for JavaScript to update the current class of #view_tab
Added the function to remove the current class from #view_tab to OSM.Index (originally in OSM.Browse)
Added missing semicolon at line 328
|
On small screens I dont think we have enough space for another tab. |
The website will auto-resize (the primary navigation will collapse). With the change, this seems to happen for screens below 715px in width with the change. Currently, this happens at 645px (for me at least). It's a difference for sure, but I don't think there are many devices that would be impacted (according to chrome devtools iPads should be fine). |
|
I've never really understood why people have such a problem with this - clicking on the site logo to return the home page has been standard web site design for like twenty years now. Our position has always been that we're so short of screen real estate that we don't want to waste any but I guess we can consider this. |
|
Related issue: #737 |
|
I'm happy with the proposed tab from a UX perspective. But from a technical PoV, I don't know enough about how the javascript stuff works to review it confidently. |
|
Since we merged #5151 we are less likely to merge this because the goal was to save space in the header. Although it still may be possible, then it's going to be a trade of History and Export for View which may still save some space. |
This is one of my two solutions (the second one being pull request #2421) to the problem of the UI not presenting a clear way to return to the "view" page. I finally realized you can just click the logo, but this isn't very clear and I've seen several people online face the same issue. This solution works by adding a "View" tab to the main navigation menu. Here's an example of it working:
.