Don't send changeset comment notifications to deleted users

openstreetmap · Oct 30, 2015 · a082bae · a082bae
1 parent 243129b
commit a082bae
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/controllers/changeset_controller.rb b/app/controllers/changeset_controller.rb
@@ -327,7 +327,7 @@ def comment
                                         :author => @user)
 
     # Notify current subscribers of the new comment
-    changeset.subscribers.each do |user|
+    changeset.subscribers.visible.each do |user|
       if @user != user
         Notifier.changeset_comment_notification(comment, user).deliver_now
       end

diff --git a/test/fixtures/changesets_subscribers.yml b/test/fixtures/changesets_subscribers.yml
@@ -5,3 +5,11 @@ t1:
 t2:
   changeset_id: 8
   subscriber_id: 1
+
+t3:
+  changeset_id: 8
+  subscriber_id: 10
+
+t4:
+  changeset_id: 8
+  subscriber_id: 11