Add tooltips, make newest/oldest buttons tooltip only

openstreetmap · Jun 12, 2024 · 7312190 · 7312190
1 parent dc8869f
commit 7312190
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/app/helpers/pagination_helper.rb b/app/helpers/pagination_helper.rb
@@ -1,9 +1,9 @@
 module PaginationHelper
-  def pagination_item(params, &block)
+  def pagination_item(params, title, &block)
     link_class = "page-link icon-link text-center"
     page_link_content = capture(&block)
     if params
-      page_link = link_to page_link_content, params, :class => link_class
+      page_link = link_to page_link_content, params, :class => link_class, :title => title
       tag.li page_link, :class => "page-item d-flex"
     else
       page_link = tag.span page_link_content, :class => link_class

diff --git a/app/views/shared/_pagination.html.erb b/app/views/shared/_pagination.html.erb
@@ -1,23 +1,25 @@
 <nav class="d-flex justify-content-between gap-2">
   <ul class="pagination">
-    <%= pagination_item(newer_id && @params.merge(:before => nil, :after => nil)) do %>
+    <%= pagination_item(newer_id && @params.merge(:before => nil, :after => nil),
+                        t(:newest, :scope => translation_scope)) do %>
       <%= previous_page_svg_tag :class => "flex-shrink-0", :count => 2 %>
-      <span class="d-none d-md-block"><%= t :newest, :scope => translation_scope %></span>
     <% end %>
   </ul>
   <ul class="pagination">
-    <%= pagination_item(newer_id && @params.merge(:before => nil, :after => newer_id)) do %>
+    <%= pagination_item(newer_id && @params.merge(:before => nil, :after => newer_id),
+                        t(:newer, :scope => translation_scope)) do %>
       <%= previous_page_svg_tag :class => "flex-shrink-0" %>
       <span class="d-none d-sm-block"><%= t :newer, :scope => translation_scope %></span>
     <% end %>
-    <%= pagination_item(older_id && @params.merge(:before => older_id, :after => nil)) do %>
+    <%= pagination_item(older_id && @params.merge(:before => older_id, :after => nil),
+                        t(:older, :scope => translation_scope)) do %>
       <span class="d-none d-sm-block"><%= t :older, :scope => translation_scope %></span>
       <%= next_page_svg_tag :class => "flex-shrink-0" %>
     <% end %>
   </ul>
   <ul class="pagination">
-    <%= pagination_item(older_id && @params.merge(:before => nil, :after => 0)) do %>
-      <span class="d-none d-md-block"><%= t :oldest, :scope => translation_scope %></span>
+    <%= pagination_item(older_id && @params.merge(:before => nil, :after => 0),
+                        t(:oldest, :scope => translation_scope)) do %>
       <%= next_page_svg_tag :class => "flex-shrink-0", :count => 2 %>
     <% end %>
   </ul>