Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preset for Scout Group #836

Merged
merged 7 commits into from
Mar 27, 2023
Merged

Add preset for Scout Group #836

merged 7 commits into from
Mar 27, 2023

Conversation

tiptoptom
Copy link
Contributor

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-836--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

tyrasd
tyrasd requested changes Mar 24, 2023
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should omit the scout field for now, as it is currently only properly used 72 times globally compared to ~4k objects with club=scout. Further, the use of the scout subtag is clustered almost exclusively around two cities in New Zealand: Wellington and Auckland. As this subtag was also never properly approved nor well documented, I would not consider it as an established tag as of now.

data/presets/club/scout.json Outdated Show resolved Hide resolved
@tiptoptom
Copy link
Contributor Author

@tyrasd what must be done to close the change request? The change is actually already incorporated.

@tyrasd tyrasd merged commit 525fe1f into openstreetmap:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
new-field new-preset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiptoptom @tyrasd