-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added highway=emergency_access_point #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your pull request. It definitely makes sense to include a preset for this feature. 👍
See the comments below for a few tweaks to be made before the preset can be merged into the index.
"terms": [ | ||
"Highway Emergency Access Point" | ||
], | ||
"name": "Highway Emergency Access Point" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I think we can find a better name for this one. Especially the word "highway" in there irritates me a bit, since these features are often found on hiking paths. What about Emergency Marker
, Emergency Location Marker
or Rescue Point
(and add the not chosen one as aliases
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But for hiking trails etc. I think emergency=access_point is more intended. highway=emergency_access_point refers I think from the tag to a road.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm… the wiki doesn't mention that highway=emergency_access_point
is limited to roadside rescue points. On the contrary, it seems to indicate that off-road rescue points are the main intended purpose behind the tag:
For areas which are hard to access, like woods or waterways, some countries offer a network of emergency access points.
Also, most examples I could find are along hiking paths, see https://overpass-turbo.eu/s/1jv1 to check yourself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, you may be right. I just wanted to create a demarcation to emergency=access_point …
But that doesn't have to be right now.
I tried to make a PR for highway=emergency_access_point. This is my first PR here so I hope, everything is fine. And if not forgive me =)
closes #20