Update marina.json #7622
Update marina.json #7622
Conversation
Moved some fields from 'moreFields' to 'Fields' to get better visability into what information is important to document with marinas. Also added a few tags that will help capture information that is helpful. Added proper seamark tags.
|
I'm not exactly sure how to propose such a change, but the sanitary_dump_station for boats is different from RVs. Simply marking it as "yes" doesn't really map it correctly and could lead to some issues with RVers navigating to the wrong location. Actually, I think I just found the proper tag... waterway=sanitary_dump_station instead of using amenity=sanitary_dump_station. |
Fixed markup (added commas).
There was a problem hiding this comment.
Looks like there are a few issues here. You can review the presets readme to learn more about the file format. Also, be sure to run npm run build:data to check for errors and include the derived data changes as well.
| "maxdraft", | ||
| "maxairdraft", | ||
| "power_supply", | ||
| "vhf_channel" |
There was a problem hiding this comment.
I don't think all these fields exist yet. You'll have to add them in files under data/presets/fields.
| "seamark:type": "harbour", | ||
| "seamark:harbour:category": "marina" |
There was a problem hiding this comment.
These should go under addTags since otherwise this preset won't match any existing features that don't have them.
| @@ -3,24 +3,28 @@ | |||
| "fields": [ | |||
| "name", | |||
| "operator", | |||
| "capacity", | |||
| "phone", | |||
There was a problem hiding this comment.
We try to limit the fields array to only a few of the most important fields since some mappers feel like they have to fill out everything. Lots of complex default fields can become intimidating. Please keep the advanced fields under moreFields.
Moved some fields from 'moreFields' to 'Fields' to get better visability into what information is important to document with marinas.
Also added a few tags that will help capture information that is helpful.
Added proper seamark tags.