Add preset subtitle property #6137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use subtitle property instead of name hack for suggestion presets
…and British English locales
Add more documentation indicating how to phrase subtitles
# Conflicts: # data/presets.yaml # data/presets/presets.json
# Conflicts: # data/presets/presets.json
|
The mechanism currently possible to deliberately not translate a This method is not described or communicated anywhere to the translators yet, but it could. The same method could be used for the subtitle descriptions that may be given for some languages, but not for others, depending on how unambiguous the word in the target language is. |
|
Putting this feature on hold. See #6412 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6131.
This adds an optional
subtitleproperty for presets that displays below the name. It also switches name suggestion presets to use it, removing some hacky code.I didn't merge this directly since it has some special implications for translations that need to be worked out. The usefulness of the subtitle depends on the language, and thus there is not a one-to-one mapping of what presets should get subtitles in English versus any other given language.
Update: I made it so subtitles don't default to English if there's no translation available.