Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make building:levels and height default fields for any building #6238

Closed
famo opened this issue Apr 24, 2019 · 9 comments
Closed

Make building:levels and height default fields for any building #6238

famo opened this issue Apr 24, 2019 · 9 comments
Assignees
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@famo
Copy link

famo commented Apr 24, 2019

I think it would be good to have building:levels and height field available for any building. Currently it is only available for some selected buildings.

@westnordost
Copy link
Contributor

I'd advise against enabling building:levels for any building. For certain buildings, it just does not make sense to specify that. (And I think it is better to have a white list rather than a black list)

FYI, StreetComplete shows the "building level quest" currently for these building types only:

house,residential,apartments,detached,terrace,dormitory,semi,semidetached_house,bungalow,
school,civic,college,university,public,hospital,kindergarten,transportation,train_station,hotel,
retail,commercial,office,warehouse,industrial,manufacture,parking,
farm,farm_auxiliary,barn,cabin

@bhousel
Copy link
Member

bhousel commented Apr 27, 2019

We won't be adding a list of "buildings where it makes sense to specify levels". If it makes sense for some types, it makes sense for all types.

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Apr 27, 2019
@westnordost
Copy link
Contributor

Not sure if your comment is about what is possible with the iD tagging preset system or about the real world in general. In case it is the latter, for your consideration, here are some examples for buildings where building:levels is not applicable because they are not made (for humans) to enter. Picked from taginfo:

the `building=roof` of this petrol station
`building=collapsed`
`building=slurry_tank`
`building=wayside_shrine`

And more.
(Though, what is conspicuous with these examples is that all of these would be things were man_made as the key would have been a better fit)

@quincylvania
Copy link
Collaborator

I think it would be good to have building:levels and height field available for any building. Currently it is only available for some selected buildings.

@famo What you're seeing is that features with just a building tag have lots of building fields while feature that also have a more specific tags like amenity=cafe don't, since they match presets that could be both buildings or non-buildings.

We could actually solve this quite easily by adding the prerequisiteTag property to all building fields so they only appear if a building tag is present on a feature. We could then add these fields to all kinds of POIs, or even just make then universal.

@westnordost I agree with Bryan on this one. Most building values will be fine most of the time, and if not users can decide for themselves when certain data is inappropriate.

@bhousel bhousel added wontfix-ISATIDL considering Not Actionable - still considering if this is something we want preset An issue with an OpenStreetMap preset or tag and removed considering Not Actionable - still considering if this is something we want wontfix-ISATIDL labels Apr 28, 2019
@famo
Copy link
Author

famo commented Apr 28, 2019

@quincylvania Actually what sparked me to create this issue, was that I missed it for garage(s) and shed and I fail to see why not enable these preset for every building...

@quincylvania
Copy link
Collaborator

@famo Oh interesting! Thanks for the further info, I hadn't even realized that some building presets didn't show all the building fields. I changed all the building presets I could see to show all the default fields. Leaving this open since we still might find a way to show some building fields for building POIs.

@famo
Copy link
Author

famo commented Apr 29, 2019

@quincylvania Does your change mean that also name and address are now enabled by default for these /every building?
Because I think those presets are really not needed by default for every building.

@quincylvania
Copy link
Collaborator

@famo For all the building presets, yes. Not every building may have these but any building could, so I think it's fine to give people those options.

@quincylvania quincylvania removed the considering Not Actionable - still considering if this is something we want label Apr 29, 2019
@quincylvania quincylvania self-assigned this Apr 29, 2019
@quincylvania quincylvania added this to the 2.15.0 milestone Apr 29, 2019
@quincylvania
Copy link
Collaborator

I added Building Levels and Building Height fields to some POIs when they are tagged as buildings. These could theoretically be added to any preset with a "building_area" field, but I think they're fine for now. We can add them as-needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

4 participants