Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presets for fitness station equipment #4373

Closed
JamesKingdom opened this issue Sep 24, 2017 · 4 comments
Closed

Add presets for fitness station equipment #4373

JamesKingdom opened this issue Sep 24, 2017 · 4 comments
Assignees
@JamesKingdom
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag

Comments

@JamesKingdom
Copy link
Collaborator

JamesKingdom commented Sep 24, 2017 •
edited by bhousel
Loading

As we are adding playground presets in #4252 , we can add fitness station presets at the same time.
@JamesKingdom JamesKingdom added the preset An issue with an OpenStreetMap preset or tag label Sep 24, 2017
@JamesKingdom JamesKingdom self-assigned this Sep 24, 2017
@bhousel
Copy link
Member

bhousel commented Sep 24, 2017

Sure, sounds good

@willemarcel
Copy link
Contributor

It already exists: https://github.com/openstreetmap/iD/blob/master/data/presets/presets/leisure/fitness_station.json

@lakedistrictOSM
Copy link

Can we add "trim trail" to the terms for fitness_station please? Thanks.

@bhousel bhousel added new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! Hacktoberfest labels Oct 1, 2017
bhousel added a commit that referenced this issue Oct 1, 2017
@bhousel
Add "trim trail" as a term for fitness station preset
b0c50bc 
(re: #4373 (comment))
@bhousel bhousel changed the title Add leisure station presets Add presets for fitness station equipment Oct 1, 2017
@bhousel
Copy link
Member

bhousel commented Oct 1, 2017

Can we add "trim trail" to the terms for fitness_station please? Thanks.

I added this term in b0c50bc..

@willemarcel we do have a generic preset for the fitness station stuff, but I think this issue is about making presets for some of the specific pieces of equipment.

@JamesKingdom JamesKingdom added the wip Work in progress label Oct 6, 2017
@bhousel bhousel removed the wip Work in progress label Nov 10, 2017
@bhousel bhousel mentioned this issue Nov 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesKingdom JamesKingdom

Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bhousel @willemarcel @JamesKingdom @lakedistrictOSM