-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name field should not be mandatory for presets #4200
Comments
I agree, there are a bunch of presets that definitely should not have a
I'm kind of undecided on what to do about it. The first option would be an easy fix. The second option would mean a change 99% of the presets, but I kind of like it because it eliminates "magic" from the code. |
I prefer the second one, even if it touches a lot of presets. The change is simple, glancing over the presets to see if |
I also prefer the second one. Eventually the presets file can be automagically compared with the taginfo-database and/or the wiki to show the most important (used) missing presets. |
I like this change, but it's strange to have the name field between other fields (and not on the top) in a preset that doesn't have it by default. Would it be possible to set the name field to always appear on the top if it's filled? |
I went to add a name to natural=wood but noticed the name field wasn't there, can the name field be added back to that preset? |
I'm not sure, but it would require some other code to be changed, maybe @bhousel has an idea.
Some presets do not come with the name tag by default, because they wouldn't normally have a name - a buffer stop is a good example of this. I'm not sure why I didn't add name to Also, if there is a preset and you want to add a name field manually, here's how you can do it: |
@JamesKingdom don't worry, I know how to add a name manually 😉 Might also want to add it back to landuse=forest. |
It was already added to forest: iD/data/presets/presets/landuse/forest.json Lines 1 to 7 in d493ee9
|
Names are important but there are lots of features in OSM which usually do not have a name. According to @bhousel, iD displays a name input field for all presets and this cannot be turned off. This leads newbies to add names and being later told by experienced mappers that they should only add names which are names.
I would like to suggest to either drop this default and force the authors of the presets to add a name field explicitly if necessary. As an alternative, preset authors could disable the name field. The latter does not require a modification of most presets but is counter-intuitive for preset authors and has the smell of being legacy. :-)
Examples where a
name=*
tag is usually wrong:The world is not simple. There are lots of parking areas which do not have a name in reality but have a pseudo-name in OSM (
name=<supermarket> parking
). But there are parking areas which have a real name. Other examples are intersections (in some regions), trees (most don't have but some have).The text was updated successfully, but these errors were encountered: