Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough updates #3921

Merged
merged 91 commits into from
Apr 18, 2017
Merged

Walkthrough updates #3921

merged 91 commits into from
Apr 18, 2017

Conversation

@runnabot
Copy link

runnabot commented Mar 22, 2017

@bhousel bhousel force-pushed the walkthrough-updates branch from 02e5ae4 to 468c1e4 Compare March 24, 2017 01:16
@bhousel bhousel force-pushed the walkthrough-updates branch from 05a428a to 6cc524a Compare March 25, 2017 04:49
@ghost
Copy link

ghost commented Apr 15, 2017

I remember seeing a similar situation to the one @mmdolbow describes ("stuck in a screen") but couldn't reproduce it.

@samanpwbb
Copy link
Member

This tutorial is a huge improvement. With a track pad, "right click" isn't meaningful:

screen shot 2017-04-15 at 2 23 41 pm

EIther say "right click or control + click" or do feature detection and cater the text to the user's setup.

@bhousel
Copy link
Member Author

bhousel commented Apr 17, 2017

Bug? After clicking the checkbox to clear the attributes dialog for a building, I got stuck in a screen like shown below.

Thanks @mmdolbow! I fixed that today.

@bhousel
Copy link
Member Author

bhousel commented Apr 18, 2017

This tutorial is a huge improvement. With a track pad, "right click" isn't meaningful:
Either say "right click or control + click" or do feature detection and cater the text to the user's setup.

Good suggestion, @samanpwbb 👍 I added some additional words to the welcome chapter, and a small interactive button-pressing task to make sure the user can left and right click.

@bhousel bhousel force-pushed the walkthrough-updates branch from 78c1eaf to e3152fb Compare April 18, 2017 06:38
@bhousel
Copy link
Member Author

bhousel commented Apr 18, 2017

Just a heads up, I'm planning to merge this today! 🎉

There are a few bugs in the snapping and undo behaviors, but I can fix those after it merges.
If there are any more last minute suggestions for adjusting the language before we unleash the translators on all this new content, let me know!

@bhousel bhousel merged commit 6f87702 into master Apr 18, 2017
@bhousel bhousel deleted the walkthrough-updates branch April 18, 2017 18:13
@magol
Copy link

magol commented Apr 21, 2017

@bhousel
Great job to create this walkthrough. I'm now working to localize it, and I have found some issues

  • When I select a node, It do not view the localized street name.
  • The address scheme should be localized to. In Sweden, the attribute "state" has no meaning and the fields is in the wrong ordet.
  • In addition, I have noted that it is somewhat inconsistent with period in the end of sentence of some instructions.

image

Edit 1:
It is also wrong in the All tags section:
image
Ideally, I would like the key addr:state to be hidden when it is not used in the address scheme.

Edit 2:

  • In the beginning of the walkthrough for buildings, it say that the building is clearly a house. But in the description for house on the wiki, it say that a house forming half of a semi-detached pair, or one of a row of terraced houses. And dit house is clearly detached. Maybe I misunderstand.

@bhousel bhousel mentioned this pull request Apr 21, 2017
3 tasks
@bhousel
Copy link
Member Author

bhousel commented Apr 21, 2017

Thanks for the feedback @magol! I moved your comments to a new issue #3976

@althio
Copy link
Contributor

althio commented Jun 19, 2017

Is there some robust link we can use to refer to the walkthrough, a 'start the walkthrough' url ?

@bhousel
Copy link
Member Author

bhousel commented Jun 19, 2017

Is there some robust link we can use to refer to the walkthrough, a 'start the walkthrough' url ?

Not currently - users are prompted to start it their first time using iD, or they can start it by opening the Help screen and clicking a button there. But we don't have a url parameter to autostart the walkthrough, if that's what you mean?

@althio
Copy link
Contributor

althio commented Jun 19, 2017 via email

@bhousel
Copy link
Member Author

bhousel commented Jun 19, 2017

Not currently - users are prompted to start it their first time using iD, or they can start it by opening the Help screen and clicking a button there. But we don't have a url parameter to autostart the walkthrough, if that's what you mean?

Yes. That would be handy.

ok added #4111 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants