upgrade ruby to 2.4.2 #1579
Closed
upgrade ruby to 2.4.2 #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm surprised this passed travis, don't think it passed locally? |
|
This PR passed the spec because .travis.yml was not changed, so it ran with the old version of ruby. |
|
Closing since we updated to 2.3.6. Can take another attempt at ruby 2.4 once we confirm 2.3.6 is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
webmockto2.3.1for ruby2.4support (Issue with ruby 2.4.0 bblimke/webmock#683 (comment)) -- a quick attempt at this exchanged the error I was getting for a ton of unhandled HTTP request VCR errors.Fixnumdeprecation warnings.