-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add codecov #17
add codecov #17
Conversation
add /* istanbul ignore next */ before page.evaluate accordingu to istanbuljs/nyc#514 (comment)
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
========================================
Coverage ? 82.6%
========================================
Files ? 1
Lines ? 69
Branches ? 7
========================================
Hits ? 57
Misses ? 12
Partials ? 0
Continue to review full report at Codecov.
|
@philschatz I found this thread istanbuljs/nyc#514 (comment) and I fixed cov_... is not defined problem but I can't tell if this is a valid solution and will not affect cov output. Can you somehow check it? |
I think that worked! To check, I found the link codecov outputted in travis
And from there, I could click around to see coverage of the commit diff as well as full coverage of converter.js The 1st commit is a little weird in codecov because there is nothing to compare against, but subsequent PR's should be more readable. Also, for what it is worth, I also use the codecov browser extension to see coverage of files when browsing github
|
I went ahead and merged this Pull Request but in the future, whoever is the last person to Accept can merge. |
this adds codecov.io (I think... check the CI status notifications & Travis to confirm) for the NodeJS code.