Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov #17

Merged
merged 3 commits into from
Jul 2, 2018
Merged

add codecov #17

merged 3 commits into from
Jul 2, 2018

Conversation

philschatz
Copy link
Member

this adds codecov.io (I think... check the CI status notifications & Travis to confirm) for the NodeJS code.

@philschatz philschatz changed the title adds codecov add codecov Jun 26, 2018
philschatz and others added 2 commits June 26, 2018 13:15
add /* istanbul ignore next */ before page.evaluate accordingu to istanbuljs/nyc#514 (comment)
@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@5f60bbf). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #17   +/-   ##
========================================
  Coverage          ?   82.6%           
========================================
  Files             ?       1           
  Lines             ?      69           
  Branches          ?       7           
========================================
  Hits              ?      57           
  Misses            ?      12           
  Partials          ?       0
Impacted Files Coverage Δ
typeset/converter.js 82.6% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f60bbf...0b26bc1. Read the comment docs.

@PiotrKozlowski
Copy link
Contributor

@philschatz I found this thread istanbuljs/nyc#514 (comment) and I fixed cov_... is not defined problem but I can't tell if this is a valid solution and will not affect cov output. Can you somehow check it?

@philschatz
Copy link
Member Author

philschatz commented Jun 27, 2018

I think that worked! To check, I found the link codecov outputted in travis

And from there, I could click around to see coverage of the commit diff as well as full coverage of converter.js

The 1st commit is a little weird in codecov because there is nothing to compare against, but subsequent PR's should be more readable. Also, for what it is worth, I also use the codecov browser extension to see coverage of files when browsing github

Codecov
Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA.

@philschatz philschatz merged commit 11bd200 into master Jul 2, 2018
@philschatz philschatz deleted the add-codecov branch July 2, 2018 15:40
@philschatz
Copy link
Member Author

I went ahead and merged this Pull Request but in the future, whoever is the last person to Accept can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants