-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the Watcher database schema #29
Create the Watcher database schema #29
Conversation
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f1e9d0c1e7064ed19c588186f7f2ef0c ✔️ noop SUCCESS in 0s |
0f71676
to
6b20bc4
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3bd641c8f255441ea7a304571759680e ✔️ noop SUCCESS in 0s |
/test functional |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3c93a45c0fc1482599ac151597bf76e5 ✔️ noop SUCCESS in 0s |
This patch creates ServiceAccount, Role and Rolebinding for the Watcher service.
This patch is adding a test to check RBAC elements created by Watcher controller and modifying existing ones to include new conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Looks good.
/approve
--- | ||
# Check for Container Image environment variables | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestAssert | ||
commands: | ||
- script: | | ||
set -euxo pipefail | ||
# If we are running the container locally, skip this test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit is implementing db schema creation (dbsync) via Job following the same pattern as other operators. It introduces some spec and status changes required and initial configuration with only the required configuration required to run the dbsync (just the database connection and transport which will be required later to pass it to the subCRs). This patch is also adding a new functional scenario test to test the Watcher controller when using non-default values. Finally, this patch is also skipping two new error types in the crd-schema-checker as it complains about perserveJobs for being a boolean type and Hash to be a map. However we want to keep them with those types for consistency with the rest of operators.
It checks the dbsync job is properly executed and conditions and hash created. And apply some fixes to be able to run kuttl tests easily when running the operator locally instead of in a container.
/lgtm |
20ecc51
into
openstack-k8s-operators:main
This PR is implementing the database schema population using
watcher-db-manage upgrade
. To do it it emplements two features:This PR also adds all functional and kuttl tests for both.
Related: OSPRH-11422