Add tests for Watcher API deployment addition

Add kuttl and funtional tests for the code responsible for creating the
Watcher API deployment.

tests/functional/base_test.go

@@ -51,6 +51,8 @@ func GetDefaultWatcherAPISpec() map[string]interface{} {
 		"databaseInstance":  "openstack",
 		"secret":            SecretName,
 		"memcachedInstance": "memcached",
+		"serviceAccount":    "watcher-sa",
+		"containerImage":    "test://watcher",
 	}
 }
 

tests/functional/watcher_test_data.go

@@ -46,6 +46,7 @@ type WatcherTestData struct {
 	RoleName                     types.NamespacedName
 	RoleBindingName              types.NamespacedName
 	WatcherDBSync                types.NamespacedName
+	WatcherAPIDeployment         types.NamespacedName
 }
 
 // GetWatcherTestData is a function that initialize the WatcherTestData
@@ -110,5 +111,9 @@ func GetWatcherTestData(watcherName types.NamespacedName) WatcherTestData {
 			Namespace: watcherName.Namespace,
 			Name:      fmt.Sprintf("%s-db-sync", watcherName.Name),
 		},
+		WatcherAPIDeployment: types.NamespacedName{
+			Namespace: watcherName.Namespace,
+			Name:      "watcher-api-api",
+		},
 	}
 }

tests/functional/watcherapi_controller_test.go

@@ -162,6 +162,31 @@ var _ = Describe("WatcherAPI controller", func() {
 				corev1.ConditionTrue,
 			)
 		})
+		It("creates a deployment for the watcher-api service", func() {
+			th.ExpectCondition(
+				watcherTest.WatcherAPI,
+				ConditionGetterFunc(WatcherAPIConditionGetter),
+				condition.DeploymentReadyCondition,
+				corev1.ConditionTrue,
+			)
+
+			deployment := th.GetDeployment(watcherTest.WatcherAPIDeployment)
+			Expect(deployment.Spec.Template.Spec.ServiceAccountName).To(Equal("watcher-sa"))
+			Expect(int(*deployment.Spec.Replicas)).To(Equal(1))
+			Expect(deployment.Spec.Template.Spec.Volumes).To(HaveLen(3))
+			Expect(deployment.Spec.Template.Spec.Containers).To(HaveLen(2))
+
+			container := deployment.Spec.Template.Spec.Containers[0]
+			Expect(container.VolumeMounts).To(HaveLen(1))
+			Expect(container.Image).To(Equal("test://watcher"))
+
+			container = deployment.Spec.Template.Spec.Containers[1]
+			Expect(container.VolumeMounts).To(HaveLen(4))
+			Expect(container.Image).To(Equal("test://watcher"))
+
+			Expect(container.LivenessProbe.HTTPGet.Port.IntVal).To(Equal(int32(9322)))
+			Expect(container.ReadinessProbe.HTTPGet.Port.IntVal).To(Equal(int32(9322)))
+		})
 	})
 	When("the secret is created but missing fields", func() {
 		BeforeEach(func() {

tests/kuttl/test-suites/default/watcher-api/03-assert.yaml

@@ -16,6 +16,10 @@ status:
     reason: Ready
     status: "True"
     type: Ready
+  - message: Deployment completed
+    reason: Ready
+    status: "True"
+    type: DeploymentReady
   - message: Input data complete
     reason: Ready
     status: "True"
@@ -34,3 +38,30 @@ kind: Secret
 metadata:
   name: watcherapi-kuttl-config-data
 type: Opaque
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: watcherapi-kuttl-api
+spec:
+  replicas: 1
+  template:
+    spec:
+      containers:
+      - name: watcherapi-kuttl-log
+      - name: watcher-api
+status:
+  readyReplicas: 1
+  replicas: 1
+---
+apiVersion: v1
+kind: Pod
+metadata:
+  labels:
+    watcher.openstack.org/name: watcherapi-kuttl
+spec:
+  containers:
+  - name: watcherapi-kuttl-log
+  - name: watcher-api
+status:
+  phase: Running

tests/kuttl/test-suites/default/watcher-api/03-deploy-watcher-api.yaml

@@ -15,3 +15,5 @@ spec:
   databaseInstance: openstack
   secret: watcherapi-secret
   memcachedInstance: "memcached"
+  containerImage: "quay.io/podified-antelope-centos9/openstack-watcher-api:current-podified"
+  serviceAccount: watcher-watcher-kuttl

tests/kuttl/test-suites/default/watcher-api/05-errors.yaml

@@ -0,0 +1,15 @@
+apiVersion: watcher.openstack.org/v1beta1
+kind: WatcherAPI
+metadata:
+  name: watcherapi-kuttl
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: watcherapi-kuttl-api
+---
+apiVersion: v1
+kind: Pod
+metadata:
+  labels:
+    watcher.openstack.org/name: watcherapi-kuttl