Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conditional assignment for BRANCH #554

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Use conditional assignment for BRANCH #554

merged 1 commit into from
Dec 13, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 3, 2024 •
edited
Loading

@stuggi stuggi requested a review from mrkisaolamb December 3, 2024 13:50
@openshift-ci openshift-ci bot requested review from lewisdenny and viroel December 3, 2024 13:50
abays
abays approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2155bbd0e4774d8bb727c65a0db35c18

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 59m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 01s
✔️ telemetry-operator-multinode-autoscaling-tempest SUCCESS in 1h 15m 03s
❌ telemetry-operator-multinode-default-telemetry FAILURE in 1h 07m 11s
✔️ functional-tests-on-osp18 SUCCESS in 1h 36m 38s (non-voting)
✔️ functional-logging-tests-osp18 SUCCESS in 1h 07m 26s (non-voting)
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 09m 43s (non-voting)
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 12m 17s (non-voting)

@vyzigold
Copy link
Contributor

vyzigold commented Dec 4, 2024

recheck - we have operators restarting (not only telemetry-operator, openstack-operator restarted too) I believe last time this was caused by lack of resources in the CI, so it's unrelated to the PR:

E1203 17:11:15.981696       1 reflector.go:147] go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1alpha1.ImageContentSourcePolicy: unknown (get imagecontentsourcepolicies.operator.openshift.io)
E1203 17:11:17.481782       1 leaderelection.go:369] Failed to update lock: Operation cannot be fulfilled on leases.coordination.k8s.io "40ba705e.openstack.org": the object has been modified; please apply your changes to the latest version and try again
I1203 17:11:19.201042       1 leaderelection.go:285] failed to renew lease openstack-operators/40ba705e.openstack.org: timed out waiting for the condition

@jlarriba
Copy link
Collaborator

jlarriba commented Dec 5, 2024

/retest

@stuggi stuggi requested a review from jlarriba December 9, 2024 15:15
@jlarriba
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, jlarriba, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyzigold
Copy link
Contributor

/retest
kuttl test issue is fixed now

@openshift-ci openshift-ci bot removed the lgtm label Dec 13, 2024
@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

rebased, should fix the pre-commit issue

@jlarriba
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
@vyzigold
Copy link
Contributor

/retest
See if the failure is consistent.

Kuttl tests failed because of infra operator:

logger.go:42: 09:23:44 | tests/5-prepare-for-edpm-power-mon | Error from server (InternalError): error when creating "../deps/dnsmasq.yaml": Internal error occurred: failed calling webhook "mdnsmasq.kb.io": failed to call webhook: Post "[https://infra-operator-controller-manager-service.openstack-operators.svc:443/mutate-network-openstack-org-v1beta1-dnsmasq?timeout=10s](https://infra-operator-controller-manager-service.openstack-operators.svc/mutate-network-openstack-org-v1beta1-dnsmasq?timeout=10s)": no endpoints available for service "infra-operator-controller-manager-service"

Infra operator failed with:

2024-12-13T09:35:18Z	ERROR	setup	problem running manager	{"error": "failed to wait for bgpconfiguration caches to sync: timed out waiting for cache to be synced for Kind *v1beta1.FRRConfiguration"}

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openstack-k8s-operators_telemetry-operator/554/pull-ci-openstack-k8s-operators-telemetry-operator-main-telemetry-operator-build-deploy-kuttl/1867480018716725248/artifacts/telemetry-operator-build-deploy-kuttl/openstack-k8s-operators-gather/artifacts/must-gather/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-3d1f620ae3617fbd6371f55aa948b34e9daf31a461d3c557cf1a7c2db38d0385/namespaces/openstack-operators/pods/infra-operator-controller-manager-8648dc6988-qjjxd/logs/manager-previous.log

@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

/test telemetry-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

added depends-on for openstack-k8s-operators/install_yamls#975 , but not sure if that will work. lets see

@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

/test telemetry-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

@stuggi
Copy link
Contributor Author

stuggi commented Dec 13, 2024

/test telemetry-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit 0020476 into openstack-k8s-operators:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@mrkisaolamb mrkisaolamb Awaiting requested review from mrkisaolamb

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@viroel viroel Awaiting requested review from viroel

@jlarriba jlarriba Awaiting requested review from jlarriba

Assignees

@jlarriba jlarriba

@abays abays

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuggi @vyzigold @jlarriba @abays