Create new secret to store ipmi configuration files #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ipmi agent uses compute agent's secret to load config files during deployment but ipmi agent only requires "hardware" pollster to be enabled to report metrics. As compute and ipmi agents are deployed by different roles, segregating their config files into different secrets makes sense. Similarly, on the compute nodes [1] takes care of storing config files into different directories. [1] openstack-k8s-operators/edpm-ansible#793
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yadneshk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yadneshk
added a commit
to yadneshk/openstack-operator
that referenced
this pull request
Oct 21, 2024
|
/hold code freeze currently enforced |
|
/unhold |
|
/lgtm |
|
/test telemetry-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit 380c601
into
openstack-k8s-operators:main
6 checks passed
yadneshk
added a commit
to yadneshk/openstack-operator
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ipmi agent uses compute agent's secret to load config files during deployment but ipmi agent only requires "hardware" pollster to be enabled to report metrics.
As compute and ipmi agents are deployed by different roles, segregating their config files into different secrets makes sense.
Similarly, on the compute nodes [1] takes care of storing config files into different directories.
[1] openstack-k8s-operators/edpm-ansible#793