Fix running reconcileDelete on new instance #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openstack-k8s-operators@dda3b1e refactored code and introduce the situation that on the just created new instance the reconcileDelete method runs which we can see from the operator log: ~~~ 2024-10-08T21:45:28Z INFO ceilometer-resource default {"name": "ceilometer"} 2024-10-08T21:45:28Z INFO ceilometer-resource validate create {"name": "ceilometer"} 2024-10-08T21:45:28Z INFO Controllers.Ceilometer Reconciling Service delete {"controller": "ceilometer", "controllerGroup": "telemetry.openstack.org", "controllerKind": "Ceilometer", "Ceilometer": {"name":"ceilometer","namespace":"openstack-kuttl-tests"}, "namespace": "openstack-kuttl-tests", "name": "ceilometer", "reconcileID": "c205bb0b-1c34-4350-969a-06c0925e0cdf"} ~~~ This change moves reconcileDelete in its own condition. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
requested review from
jlarriba and
paramite
and removed request for
viroel
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlarriba, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ae8ae90
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dda3b1e refactored code and introduce the situation that on the just created new instance the reconcileDelete method runs which we can see from the operator log:
This change moves reconcileDelete in its own condition.