[OSPRH-8065] Rework custom prometheus CA #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework how the user specifies CA certificates for user deployed / external prometheus. Before the PR the user deployed prometheus was almost unusable. The TLS was always used no matter the settings (which was a bug). The operator also assumed that the CA cert is a part of the openstack ca bundle. This assumption doesn't make sense for external prometheus. With this PR the user has an option to specify a secret name and key within that secret which holds the CA certificate. The functionality around using the metric-storage prometheus by default is still unchanged and works with and without controlplane TLS as before.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold until GA content is branched |
|
/unhold |
|
/lgtm |
openshift-merge-bot
bot
merged commit 3c3fb82
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how the user specifies CA certificates for
user deployed / external prometheus.
Before the PR the user deployed
prometheus was almost unusable. The TLS was always used no matter the settings (which was a bug). The operator also assumed that the CA cert is a part of the openstack ca bundle. This assumption doesn't make sense for external prometheus.
With this PR the user has an option to specify a secret name and key within that secret which holds the CA certificate.
The functionality around using the metric-storage prometheus by default is still unchanged and works with and without controlplane TLS as before.