Removing RabbitMQ replace #426
Conversation
It's possible the replace isn't needed anymore. It was there to unblock CI back then. If we can't just remove it, we could at least update it to newer version.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold until GA content is branched. |
|
The CI passed, so it looks like the line isn't needed anymore. It was added after openstackversions was introduced and if I remember correctly, part of the issue was our dependency on dataplane-operator. The merge of openstack-operator and dataplane-operator might be the reason why we don't need this anymore. |
|
/unhold |
|
Could we please extend this PR to also add the other dependency change that Gibi realized it was not useful? Im referring to also remove the line https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/go.mod#L89 and let the CI run again. |
|
/lgtm |
|
/retest |
openshift-merge-bot
bot
merged commit 76945a2
into
openstack-k8s-operators:main
It's possible the replace isn't needed anymore. It was there to unblock CI back then. If we can't just remove it, we could at least update it to newer version.