Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaultConfig regression #182

Conversation

cschwede
Copy link
Collaborator

The script condition failed if there were additional files.

Adding an sample key and kuttl test to ensure there is no future regression.

@openshift-ci openshift-ci bot requested review from lewisdenny and viroel March 25, 2024 05:33
@abays
Copy link
Contributor

abays commented Mar 25, 2024

@cschwede: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/functional 741aca8 link true /test functional

Full PR test history. Your PR dashboard.

I think we need this change to be added to this repo for now: openstack-k8s-operators/openstack-operator#723

@abays
Copy link
Contributor

abays commented Mar 25, 2024

@cschwede: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/functional 741aca8 link true /test functional
Full PR test history. Your PR dashboard.

I think we need this change to be added to this repo for now: openstack-k8s-operators/openstack-operator#723

Created here: #183

The script condition failed if there were additional files.

Adding an sample key and kuttl test to ensure there is no future
regression.
@cschwede cschwede force-pushed the fix-defaultconfig-regression branch from 741aca8 to 560d184 Compare March 25, 2024 14:14
@cschwede
Copy link
Collaborator Author

@cschwede: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/functional 741aca8 link true /test functional
Full PR test history. Your PR dashboard.

I think we need this change to be added to this repo for now: openstack-k8s-operators/openstack-operator#723

Created here: #183

Thx @abays , merged & rebased this patch.

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, cschwede

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e4f8d24 into openstack-k8s-operators:main Mar 25, 2024
5 checks passed
@cschwede cschwede deleted the fix-defaultconfig-regression branch March 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants