-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset connection when turning off TLS #357
Conversation
Jira: OSPRH-10415
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olliewalsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The code looks correct. Should we add a kuttl test to validate that tls disabled removes the records? (Not sure it affects more than that. Does the service still start successfully if these records are left lingering?) |
Basic tests work for me at least - Disabling podLevel TLS on the controlplane and dataplane succeeds, previously neutronapi would fail to connect the the sb db.
|
/cherry-pick 18.0.0-proposed |
@olliewalsh: once the present PR merges, I will cherry-pick it on top of 18.0.0-proposed in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
Replaced with #361 |
Jira: OSPRH-10415