Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset connection when turning off TLS #357

Closed

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Sep 27, 2024

Jira: OSPRH-10415

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh olliewalsh requested review from karelyatin and removed request for beagles and frenzyfriday September 27, 2024 14:17
@booxter
Copy link
Contributor

booxter commented Sep 27, 2024

The code looks correct. Should we add a kuttl test to validate that tls disabled removes the records? (Not sure it affects more than that. Does the service still start successfully if these records are left lingering?)

@olliewalsh
Copy link
Contributor Author

olliewalsh commented Sep 27, 2024

The code looks correct. Should we add a kuttl test to validate that tls disabled removes the records? (Not sure it affects more than that. Does the service still start successfully if these records are left lingering?)

Basic tests work for me at least - Disabling podLevel TLS on the controlplane and dataplane succeeds, previously neutronapi would fail to connect the the sb db.

del-ssl could possibly be omitted, have not tested without it.

@olliewalsh
Copy link
Contributor Author

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@olliewalsh: once the present PR merges, I will cherry-pick it on top of 18.0.0-proposed in a new PR and assign it to you.

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh
Copy link
Contributor Author

/hold

@olliewalsh
Copy link
Contributor Author

Replaced with #361

@olliewalsh olliewalsh closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants