Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Moving to 1.21 #886

Closed
wants to merge 1 commit into from
Closed

[WIP] Moving to 1.21 #886

wants to merge 1 commit into from

Conversation

jpodivin
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from fao89 and lewisdenny June 25, 2024 13:25
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@stuggi
Copy link
Contributor

stuggi commented Jun 25, 2024

is this something we intend to do before GA? iirc last time we discussed that in the weekly sync call it was a post GA task, or has this changed?

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/61293a5f89244a07a1b171f47b81ff19

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 13m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 55s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 08s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 39m 27s
openstack-operator-tempest-multinode POST_FAILURE in 1h 59m 10s

@jpodivin jpodivin force-pushed the go-1.21 branch 2 times, most recently from 06e4cda to d9fafc4 Compare June 26, 2024 10:49
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

@jpodivin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl d9fafc4 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpodivin jpodivin changed the title Moving to 1.21 [WIP] Moving to 1.21 Jun 26, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/02fc45d80b6646b0b6b2e6bd4d70cc2a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 36s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 07s
cifmw-data-plane-adoption-osp-17-to-extracted-crc NODE_FAILURE Node request 099-0007393892 failed in 0s
✔️ openstack-operator-tempest-multinode SUCCESS in 2h 04m 18s

@bshephar
Copy link
Contributor

is this something we intend to do before GA? iirc last time we discussed that in the weekly sync call it was a post GA task, or has this changed?

I think we're still aiming for post GA. There's a bunch of supporting work that needs to be done, so there's probably value in capturing where CI fails with this and recording what needs to happen to get it all passing.

I see it's been opened with [WIP], probably for that very reason. We can probably just mark this as draft once we've captured the CI failures.

@stuggi
Copy link
Contributor

stuggi commented Jun 27, 2024

is this something we intend to do before GA? iirc last time we discussed that in the weekly sync call it was a post GA task, or has this changed?

I think we're still aiming for post GA. There's a bunch of supporting work that needs to be done, so there's probably value in capturing where CI fails with this and recording what needs to happen to get it all passing.

I see it's been opened with [WIP], probably for that very reason. We can probably just mark this as draft once we've captured the CI failures.

when I looked/commented it did not have the [WIP], thanks for adding it!

@jpodivin
Copy link
Contributor Author

is this something we intend to do before GA? iirc last time we discussed that in the weekly sync call it was a post GA task, or has this changed?

I think we're still aiming for post GA. There's a bunch of supporting work that needs to be done, so there's probably value in capturing where CI fails with this and recording what needs to happen to get it all passing.
I see it's been opened with [WIP], probably for that very reason. We can probably just mark this as draft once we've captured the CI failures.

when I looked/commented it did not have the [WIP], thanks for adding it!

That's on me. I forgot to put it there when I opened it. Sorry.

@bshephar
Copy link
Contributor

/recheck

Signed-off-by: Jiri Podivin <[email protected]>
@jpodivin jpodivin closed this Jun 28, 2024
@jpodivin jpodivin deleted the go-1.21 branch June 28, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants