-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate galera templates storageRequest via validation webhook #882
Validate galera templates storageRequest via validation webhook #882
Conversation
This change depends on a change that failed to merge. Changes openstack-k8s-operators/lib-common#522, openstack-k8s-operators/mariadb-operator#234 are needed. |
d37b929
to
101ac83
Compare
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like: $ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G! Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G! Depends-On: openstack-k8s-operators/lib-common#522 Depends-On: openstack-k8s-operators/mariadb-operator#234 Signed-off-by: Martin Schuppert <[email protected]>
101ac83
to
aa9196a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/fe46947e5f6045b9b330ae8d321601f6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 50s |
recheck |
/retest |
2d315a0
into
openstack-k8s-operators:main
Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like:
Depends-On: openstack-k8s-operators/lib-common#522
Depends-On: openstack-k8s-operators/mariadb-operator#234