Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate galera templates storageRequest via validation webhook #882

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Jun 24, 2024

Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like:

$ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml
Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G!
Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G!

Depends-On: openstack-k8s-operators/lib-common#522
Depends-On: openstack-k8s-operators/mariadb-operator#234

Copy link

This change depends on a change that failed to merge.

Changes openstack-k8s-operators/lib-common#522, openstack-k8s-operators/mariadb-operator#234 are needed.

@stuggi stuggi requested review from dciabrin and abays and removed request for lewisdenny June 24, 2024 12:43
@stuggi stuggi force-pushed the storage_request_webhook branch 2 times, most recently from d37b929 to 101ac83 Compare June 24, 2024 15:07
Notify the enduser if the configured DB storageRequest is
too low for production use. It is not blocking to allow lower
settings for test/ci systems. The output would be like:

$ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml
Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G!
Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G!

Depends-On: openstack-k8s-operators/lib-common#522
Depends-On: openstack-k8s-operators/mariadb-operator#234

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi force-pushed the storage_request_webhook branch from 101ac83 to aa9196a Compare June 24, 2024 15:08
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fe46947e5f6045b9b330ae8d321601f6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 50s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 09m 24s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 36m 57s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 48m 43s

@stuggi
Copy link
Contributor Author

stuggi commented Jun 25, 2024

recheck

@abays
Copy link
Contributor

abays commented Jun 25, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 2d315a0 into openstack-k8s-operators:main Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants