Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataplane docs #851

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add dataplane docs #851

merged 1 commit into from
Jun 17, 2024

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Jun 14, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from igallagh-redhat and rabi June 14, 2024 11:33
@fao89 fao89 force-pushed the dataplanedocs branch 8 times, most recently from d054eec to 7e6f5b2 Compare June 14, 2024 13:49
@fao89 fao89 requested a review from rebtoor June 14, 2024 13:51
@fao89 fao89 mentioned this pull request Jun 14, 2024
Merged
jpodivin
jpodivin requested changes Jun 17, 2024
View reviewed changes
.github/workflows/docs.yaml Outdated
git config user.name github-actions
git config user.email [email protected]

git branch -D gh-pages &>/dev/null || true
git checkout -b gh-pages 4cd0193fc6c5bc7e76f3a0148d0447fb0d7fbe6a
git revert 4cd0193fc6c5bc7e76f3a0148d0447fb0d7fbe6a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about why are we reverting this.

Copy link
Contributor Author

@fao89 fao89 Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was just for creating an empty branch, but I found a better way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for --orphan usage

@fao89
Add dataplane docs
52401d5 
Signed-off-by: Fabricio Aguiar <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fao89
Copy link
Contributor Author

fao89 commented Jun 17, 2024

/test openstack-operator-build-deploy-kuttl

Waiting the cluster to be up
..........................................................................................make: *** [Makefile:2098: ceph] Error 1

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7cf2937cb7a54b2a82f574ed12c977ab

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 13s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 22m 25s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 38m 20s
✔️ openstack-operator-docs-preview SUCCESS in 2m 05s

@fao89
Copy link
Contributor Author

fao89 commented Jun 17, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit d6b6a34 into openstack-k8s-operators:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebtoor rebtoor rebtoor approved these changes

@jpodivin jpodivin jpodivin requested changes

@igallagh-redhat igallagh-redhat Awaiting requested review from igallagh-redhat

@rabi rabi Awaiting requested review from rabi

Assignees

@rebtoor rebtoor

@jpodivin jpodivin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @rebtoor @jpodivin