Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Glance with the new storage interface #843

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Jun 12, 2024

We currently provide both StorageClass and StorageRequest that can be propagated to the Glance underlying instances.
However, it might be possible that operators use extraMounts to plug a NFS share mapped to /var/lib/glance/os_glance_staging_store.
In this case the API should be updated to not provision any PVC and let the human operator take care about it via the extraMounts interface.

This patch updates the Glance bits to reflect the new behavior introduced in the glance-operator.

Jira: https://issues.redhat.com/browse/OSPRH-6719

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a533394efe2a43db8e4dd31d9e9ab161

openstack-k8s-operators-content-provider FAILURE in 14m 13s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@fmount fmount force-pushed the glance_storage_interface branch 2 times, most recently from 584d7dc to 3c4dfcb Compare June 14, 2024 17:00
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3e7426c693964c88be528a5562fef354

openstack-k8s-operators-content-provider FAILURE in 12m 22s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@fmount fmount force-pushed the glance_storage_interface branch 2 times, most recently from 7276f70 to f44874b Compare June 14, 2024 20:23
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/61649eddcfa64571af49356274bddd29

openstack-k8s-operators-content-provider FAILURE in 13m 33s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@fmount fmount force-pushed the glance_storage_interface branch 4 times, most recently from 708354f to 64d3e84 Compare June 17, 2024 14:51
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5de30ad461b7444e8693443c379e7d2d

openstack-k8s-operators-content-provider FAILURE in 11m 55s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@fmount
Copy link
Contributor Author

fmount commented Jun 17, 2024

/retest-required

@fmount fmount force-pushed the glance_storage_interface branch 4 times, most recently from 215b310 to 10751f4 Compare June 17, 2024 20:53
@fmount
Copy link
Contributor Author

fmount commented Jun 18, 2024

/test precommit-check

Copy link

@konan-abhi konan-abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@fmount
Copy link
Contributor Author

fmount commented Jun 18, 2024

@fao89 do you know what's going on w/ make docs ? I tried it locally and it doesn't change anything compared to what I already pushed here, but I'm wondering if I'm missing something.

@stuggi stuggi mentioned this pull request Jun 18, 2024
1 task
@fao89
Copy link
Contributor

fao89 commented Jun 18, 2024

@fmount I don't know what is happening, but I checkout this PR, ran make docs and it did change. My best guess is something with the binaries, I would try deleting what you have on openstack-operator/bin and run make docs again to see if it changes the docs for you

@fmount
Copy link
Contributor Author

fmount commented Jun 18, 2024

@fmount I don't know what is happening, but I checkout this PR, ran make docs and it did change. My best guess is something with the binaries, I would try deleting what you have on openstack-operator/bin and run make docs again to see if it changes the docs for you

@fmount I don't know what is happening, but I checkout this PR, ran make docs and it did change. My best guess is something with the binaries, I would try deleting what you have on openstack-operator/bin and run make docs again to see if it changes the docs for you

I think it's bundle that makes the difference, and it's not in openstack-operator/bin. I'll look into that but so far I'm not able to reproduce (locally) that issue.

@fao89
Copy link
Contributor

fao89 commented Jun 18, 2024

it makes sense, try to replace manifests with bundle on the docs dependencies: https://github.com/openstack-k8s-operators/openstack-operator/blob/main/Makefile#L94

So there are weird things happening with ruby and bundle: do we enforce a specific version?

@fmount fmount force-pushed the glance_storage_interface branch from 10751f4 to 0ec9f1c Compare June 18, 2024 09:51
@openshift-ci openshift-ci bot removed the lgtm label Jun 18, 2024
@fmount
Copy link
Contributor Author

fmount commented Jun 18, 2024

it makes sense, try to replace manifests with bundle on the docs dependencies: https://github.com/openstack-k8s-operators/openstack-operator/blob/main/Makefile#L94

So there are weird things happening with ruby and bundle: do we enforce a specific version?

ok the combination of fedora40 with ruby-v3.3 did the trick, but if I slightly change version(s) (even for the asciidoctor) gem I generate a diff output.
@fao89 now pre-commit check passes, thanks for the help!

@fmount fmount requested a review from konan-abhi June 18, 2024 10:15
@fmount
Copy link
Contributor Author

fmount commented Jun 18, 2024

/test openstack-operator-build-deploy-kuttl

1 similar comment
@fmount
Copy link
Contributor Author

fmount commented Jun 18, 2024

/test openstack-operator-build-deploy-kuttl

We currently provide both StorageClass and StorageRequest that can be
propagated to the Glance underlying instances.
However, it might be possible that operators use extraMounts to plug a
NFS share mapped to /var/lib/glance/os_staging_store.
In this case, the API should be updated to not provision any PVC and
let the human operator to take care about it using the extraMounts
interface.
This patch updates the Glance bits to reflect the new behavior
introduced in the glance-operator.

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount force-pushed the glance_storage_interface branch from 0ec9f1c to 5217e8c Compare June 18, 2024 14:46
@fmount fmount requested a review from stuggi June 18, 2024 18:31
@fmount
Copy link
Contributor Author

fmount commented Jun 19, 2024

@abays @stuggi @konan-abhi we have green CI here and I'm wondering if we can land this

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmount
Copy link
Contributor Author

fmount commented Jun 19, 2024

/test openstack-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, konan-abhi, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor Author

fmount commented Jun 19, 2024

mm rechecking kuttl as it seems failing on FIPS check :/
I don't recall any recent upstream change related to FIPS.

Looks like openshift/check-payload#197 will fix the current failure.

@fmount
Copy link
Contributor Author

fmount commented Jun 19, 2024

/test openstack-operator-build-deploy-kuttl

@fmount
Copy link
Contributor Author

fmount commented Jun 19, 2024

/test openstack-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit ccb7826 into openstack-k8s-operators:main Jun 19, 2024
9 checks passed
fmount added a commit to fmount/architecture that referenced this pull request Jun 20, 2024
We recently merged [1][2] and the Glance API have been updated to
reflect the new storage interface.
This patch aligns architectures repo CRs with the new structure.

[1] openstack-k8s-operators/glance-operator#554
[2] openstack-k8s-operators/openstack-operator#843

Jira: https://issues.redhat.com/browse/OSPRH-6719

Signed-off-by: Francesco Pantano <[email protected]>
softwarefactory-project-zuul bot added a commit to openstack-k8s-operators/architecture that referenced this pull request Jun 20, 2024
Update glance storageClass propagation

We recently merged [1][2] and the Glance API have been updated to reflect the new storage interface.
This patch aligns architectures repo CRs with the new structure.
[1] openstack-k8s-operators/glance-operator#554
[2] openstack-k8s-operators/openstack-operator#843
Jira: https://issues.redhat.com/browse/OSPRH-6719

Reviewed-by: Andrew Bays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants