Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tls] Improve the TLS kuttl scenarios #797

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[tls] Improve the TLS kuttl scenarios #797

merged 1 commit into from
Jul 18, 2024

Conversation

Deydra71
Copy link
Contributor

@Deydra71 Deydra71 commented May 14, 2024 •
edited
Loading

Test scenarios:

  • Custom Issuer
    • Deploy with the default internal issuer, then switch to a custom internal issuer (and vice versa),
    • Deploy with the default ingress issuer, then switch to a custom ingress issuer (and vice versa),
  • Service Certificate Rotation
    • After deployment, certificate secrets are deleted, triggering service restarts. The test checks whether new secrets are mounted in service pods and if route configurations use these new secrets.
  • Custom CA cert added to a bundle
  • Customize cert and CA cert duration parameters

Test scenarios to be added:
CA cert rotation

@openshift-ci openshift-ci bot requested review from lewisdenny and viroel May 14, 2024 07:29
@Deydra71 Deydra71 requested review from olliewalsh, stuggi and vakwetu and removed request for lewisdenny and viroel May 14, 2024 07:29
Deydra71 added a commit to Deydra71/dev-docs that referenced this pull request May 14, 2024
@Deydra71
[tls] Add kuttl scenarios description
a8eb348 
Depends-On: openstack-k8s-operators/openstack-operator/pull/797
Signed-off-by: Veronika Fisarova <[email protected]>
@Deydra71 Deydra71 mentioned this pull request May 14, 2024
Merged
@Deydra71
Copy link
Contributor Author

Deydra71 commented May 14, 2024 •
edited
Loading

The kuttl test may be failing because Swift remains in a NotReady condition, even though all pods have been successfully restarted with new secrets. In the local testing environment, simply deleting the Swift pods was enough to trigger a change to the ready condition. This issue has already been discussed with @stuggi, and it is on the todo list after the freeze.

@Deydra71 Deydra71 force-pushed the tls-kuttl branch 3 times, most recently from 513f02d to df39c98 Compare May 16, 2024 07:34
@Deydra71
Copy link
Contributor Author

Deydra71 commented May 16, 2024 •
edited
Loading

The scripts are now using cert-manager label controller.cert-manager.io/fao=true to delete service and route secrets. The core.openstack.org/openstackcontrolplane label is now used to query the ctlplane without specifying the object name.

Deydra71 added a commit to Deydra71/dev-docs that referenced this pull request May 30, 2024
@Deydra71
[tls] Add kuttl scenarios description
043e9db 
Depends-On: openstack-k8s-operators/openstack-operator/pull/797
Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71 added a commit to Deydra71/dev-docs that referenced this pull request May 30, 2024
@Deydra71
[tls] Add kuttl scenarios description
faff427 
...and enhancements/corrections.

Depends-On: openstack-k8s-operators/openstack-operator/pull/797
Signed-off-by: Veronika Fisarova <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/71d6563eb9f5403fa274c9b23ab38fee

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 34s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 10m 27s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 45s
❌ openstack-operator-tempest-multinode POST_FAILURE in 1h 50m 42s

@Deydra71
Copy link
Contributor Author

recheck

@stuggi stuggi mentioned this pull request Jun 5, 2024
Closed
Deydra71 added a commit to Deydra71/dev-docs that referenced this pull request Jun 6, 2024
@Deydra71
[tls] Add kuttl scenarios description
8c4d32d 
...and enhancements/corrections.

Depends-On: openstack-k8s-operators/openstack-operator/pull/797
Signed-off-by: Veronika Fisarova <[email protected]>
@Deydra71 Deydra71 force-pushed the tls-kuttl branch 2 times, most recently from 7419365 to ce03d30 Compare June 6, 2024 13:55
@stuggi
Copy link
Contributor

stuggi commented Jul 12, 2024

/test openstack-operator-build-deploy-kuttl

1 similar comment
@stuggi
Copy link
Contributor

stuggi commented Jul 12, 2024

/test openstack-operator-build-deploy-kuttl

@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

1 similar comment
@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

3 similar comments
@stuggi
Copy link
Contributor

stuggi commented Jul 15, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Jul 15, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Jul 16, 2024

/test openstack-operator-build-deploy-kuttl

@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

2 similar comments
@stuggi
Copy link
Contributor

stuggi commented Jul 16, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Jul 16, 2024

/test openstack-operator-build-deploy-kuttl

@Deydra71
[tls] Improve the TLS kuttl scenarios
78f6fbb 
Signed-off-by: Veronika Fisarova <[email protected]>
@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

5 similar comments
@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@Deydra71
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Jul 18, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Jul 18, 2024

/test openstack-operator-build-deploy-kuttl

olliewalsh
olliewalsh reviewed Jul 18, 2024
View reviewed changes
tests/kuttl/common/osp_check_cert_issuer.sh
host_port=$(echo "$endpoint_url" | sed -E 's|^[^:/]+://([^:/]+).*|\1|')
else
# Extract the hostname and port for internal endpoints, keeping the port if specified
host_port=$(echo "$endpoint_url" | sed -E 's|^[^:/]+://([^:/]+(:[0-9]+)?).*|\1|')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could just use this for both endpoint types

stuggi
stuggi approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Deydra71, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit df26588 into openstack-k8s-operators:main Jul 18, 2024
8 checks passed
Deydra71 added a commit to Deydra71/dev-docs that referenced this pull request Jul 22, 2024
@Deydra71
[tls] Add kuttl scenarios description
4ab755a 
...and enhancements/corrections.

Depends-On: openstack-k8s-operators/openstack-operator/pull/797
Signed-off-by: Veronika Fisarova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliewalsh olliewalsh olliewalsh left review comments

@stuggi stuggi stuggi approved these changes

@vakwetu vakwetu Awaiting requested review from vakwetu

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Deydra71 @stuggi @morucci @olliewalsh @openshift-merge-robot