Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type label to osctlplane object #760

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Apr 17, 2024

Adds map[string]string{"core.openstack.org/openstackcontrolplane": ""} to the instance, if not already provided in the CR. With this ctlplane object can be queried using the default label. Which is useful e.g. in tests to query the ctlplane in a generic way without the object name.

@openshift-ci openshift-ci bot requested review from dprince and lewisdenny April 17, 2024 12:56
@stuggi stuggi requested review from abays and removed request for lewisdenny April 17, 2024 12:56
@stuggi
Copy link
Contributor Author

stuggi commented Apr 17, 2024

useful to do something like this
oc wait openstackcontrolplane -n <namespace> --for condition=Ready --timeout <timeout> -l <label>

Adds map[string]string{"core.openstack.org/openstackcontrolplane": ""}
to the instance, if not already provided in the CR. With this
ctlplane object can be queried using the default label. Which
is useful e.g. in tests to query the ctlplane in a generic way
without the object name.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e2c2bb992be940609a358775f15ede45

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 39s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 31s
cifmw-crc-podified-edpm-baremetal FAILURE in 22m 00s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 35m 07s

@stuggi
Copy link
Contributor Author

stuggi commented Apr 18, 2024

recheck

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 24d9eab into openstack-k8s-operators:main Apr 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants