Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove networkAttachment for ovnNorthd #759

Conversation

umago
Copy link
Contributor

@umago umago commented Apr 17, 2024

ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the sample files.

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

Hi @umago. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karelyatin
Copy link
Contributor

/ok-to-test

@booxter
Copy link
Contributor

booxter commented Apr 17, 2024

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a3c17290712f4ec8a20ac2e4d2e3bff6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 20s
openstack-operator-tempest-multinode FAILURE in 1h 38m 20s

@karelyatin
Copy link
Contributor

recheck live migration tests

/lgtm

umago added a commit to umago/ovn-operator that referenced this pull request Apr 19, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
umago added a commit to umago/ovn-operator that referenced this pull request Apr 19, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
umago added a commit to umago/ovn-operator that referenced this pull request Apr 19, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
umago added a commit to umago/ovn-operator that referenced this pull request Apr 19, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
@booxter
Copy link
Contributor

booxter commented Apr 22, 2024

Removed "Closes" tag since we need an ovn-operator PR too.

@umago
Copy link
Contributor Author

umago commented Apr 22, 2024

Removed "Closes" tag since we need an ovn-operator PR too.

Good point! Let me get rid of that tag

ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the sample files.

Signed-off-by: Lucas Alvares Gomes <[email protected]>
@umago umago force-pushed the ovnNorthd-networkAttachment branch from 3706724 to 83b7451 Compare April 22, 2024 12:55
@openshift-ci openshift-ci bot removed the lgtm label Apr 22, 2024
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@booxter
Copy link
Contributor

booxter commented Apr 22, 2024

/lgtm

@booxter
Copy link
Contributor

booxter commented Apr 22, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, dprince, stuggi, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprince
Copy link
Contributor

dprince commented Apr 23, 2024

/override ci/prow/openstack-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@dprince: Overrode contexts on behalf of dprince: ci/prow/openstack-operator-build-deploy-kuttl

In response to this:

/override ci/prow/openstack-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 82f5304 into openstack-k8s-operators:main Apr 23, 2024
7 checks passed
umago added a commit to umago/ovn-operator that referenced this pull request Apr 23, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Depends-On: openstack-k8s-operators/lib-common#496
Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
umago added a commit to umago/ovn-operator that referenced this pull request Apr 23, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Depends-On: openstack-k8s-operators/lib-common#496
Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
umago added a commit to umago/ovn-operator that referenced this pull request Apr 23, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
umago added a commit to umago/ovn-operator that referenced this pull request Apr 23, 2024
ovnNorthd does not require additional interface via networkAttachment,
this patch removes it from the API and controller code.

Patches removing it from the docs and sample files:

* openstack-k8s-operators/openstack-operator#759
* openstack-k8s-operators/data-plane-adoption#408
* openstack-k8s-operators/architecture#186

Closes: OSPRH-659
Signed-off-by: Lucas Alvares Gomes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants