-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove networkAttachment for ovnNorthd #759
Remove networkAttachment for ovnNorthd #759
Conversation
Hi @umago. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a3c17290712f4ec8a20ac2e4d2e3bff6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 46s |
recheck live migration tests /lgtm |
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
Removed "Closes" tag since we need an ovn-operator PR too. |
Good point! Let me get rid of that tag |
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the sample files. Signed-off-by: Lucas Alvares Gomes <[email protected]>
3706724
to
83b7451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: booxter, dprince, stuggi, umago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/openstack-operator-build-deploy-kuttl |
@dprince: Overrode contexts on behalf of dprince: ci/prow/openstack-operator-build-deploy-kuttl In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
82f5304
into
openstack-k8s-operators:main
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Depends-On: openstack-k8s-operators/lib-common#496 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Depends-On: openstack-k8s-operators/lib-common#496 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the API and controller code. Patches removing it from the docs and sample files: * openstack-k8s-operators/openstack-operator#759 * openstack-k8s-operators/data-plane-adoption#408 * openstack-k8s-operators/architecture#186 Closes: OSPRH-659 Signed-off-by: Lucas Alvares Gomes <[email protected]>
ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the sample files.