Add test operator into the openstack-operator-index #752
Conversation
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/491617132baf4a99a93badec27c0cc68 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 00s |
|
/test openstack-operator-build-deploy-kuttl |
lpiwowar
force-pushed
the
add-test-operator
branch
2 times, most recently
from
83f70f2 to
c209f7f
Compare
With this change [1] we moved the test-operator to openstack-operator-index. Let's update the documentation to reflect this. [1] openstack-k8s-operators/openstack-operator#752 Depends-On: openstack-k8s-operators/openstack-operator#752
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f42725c46b7e474d90c430340c545e71 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 58s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/401b07b847ed4512b6eee963ae9f5b6b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 51s |
|
recheck |
lpiwowar
force-pushed
the
add-test-operator
branch
from
c209f7f to
4bbf8b8
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/deccf7558a454ba5ae64862a03c1862c ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 31s |
|
recheck |
|
@abays, @frenzyfriday, @viroel or @kopecmartin -> I'm sorry for the ping. Can I ask for a review please? |
|
The logic here would always pull the latest test-operator? But every other operator we have integrated with openstack-operator is either promoted (by editing the go.mod file ... typically via Renovate) or pinned explicitly like rabbitmq to a version that we manually bump. I'm not sure I agree we should go this route. Would a promotion process serve us better? |
hack/pin-bundle-images.sh
Outdated
|
|
||
| REPO_CURL_URL="https://quay.io/api/v1/repository/openstack-k8s-operators" | ||
| SHA=$(curl -s ${REPO_CURL_URL}/test-operator-bundle/tag/?onlyActiveTags=true?limit=100 | jq -r .tags[].name | sort -u | head -n 1) | ||
| echo -n ",quay.io/openstack-k8s-operators/test-operator-bundle:${SHA}" |
There was a problem hiding this comment.
rather than this we could add a mute go.mod entry by importing the scheme for test-operator into main.go. And thereby have a promotion for this operator.
There was a problem hiding this comment.
Yes, this sounds like a better solution. I wanted to modify the go.mod entry but I wasn't sure whether it is correct thing to do when test-operator is not direct a requirement for the openstack-operator.
lpiwowar
force-pushed
the
add-test-operator
branch
from
4bbf8b8 to
c5bf29b
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
lpiwowar
force-pushed
the
add-test-operator
branch
from
c5bf29b to
d807e15
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9301798b97574712a24777cbe9e40af9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 36m 22s |
|
/hold lets hold for now, there is still ongoing discussion how the test-operator gets included |
lpiwowar
force-pushed
the
add-test-operator
branch
from
7533c12 to
f3f06e6
Compare
| @@ -53,6 +53,7 @@ import ( | |||
| placementv1 "github.com/openstack-k8s-operators/placement-operator/api/v1beta1" | |||
| swiftv1 "github.com/openstack-k8s-operators/swift-operator/api/v1beta1" | |||
| telemetryv1 "github.com/openstack-k8s-operators/telemetry-operator/api/v1beta1" | |||
| _ "github.com/openstack-k8s-operators/test-operator/api/v1beta1" | |||
There was a problem hiding this comment.
while the dash here implies meaning, it might be worth adding an explicit comment on this one so that someone doesn't come along and remove it afterwards
There was a problem hiding this comment.
Got it, thank you, done!
lpiwowar
force-pushed
the
add-test-operator
branch
from
f3f06e6 to
4c457b6
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cf4a8877cb014356a91997111b606c74 ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 05m 21s |
lpiwowar
force-pushed
the
add-test-operator
branch
from
4c457b6 to
b7c34a8
Compare
lpiwowar
force-pushed
the
add-test-operator
branch
from
b7c34a8 to
7e5448b
Compare
This patch adds the test-operator into the openstack-operator-index. Up until now the test-operator had its own index called test-operator-index [1]. [1] https://quay.io/repository/openstack-k8s-operators/test-operator-index
lpiwowar
force-pushed
the
add-test-operator
branch
from
7e5448b to
a61502c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ab27ace
into
openstack-k8s-operators:main
With this change [1] we moved the test-operator to openstack-operator-index. Let's update the documentation to reflect this. [1] openstack-k8s-operators/openstack-operator#752 Depends-On: openstack-k8s-operators/openstack-operator#752
With this change [1] we moved the test-operator to openstack-operator-index. Let's update the documentation to reflect this. [1] openstack-k8s-operators/openstack-operator#752 Depends-On: openstack-k8s-operators/openstack-operator#752
With this change [1] we moved the test-operator to openstack-operator-index. Let's update the documentation to reflect this. [1] openstack-k8s-operators/openstack-operator#752 Depends-On: openstack-k8s-operators/openstack-operator#752
This patch adds the test-operator into the openstack-operator-index.
Up until now the test-operator had its own index called
test-operator-index [1].
[1] https://quay.io/repository/openstack-k8s-operators/test-operator-index