Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/Restore condition transition time for control plane #750

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Apr 12, 2024

This is needed as we are resetting the condition state of each reconcile
but the changing lastTransitionTime field causes reconcile loops.

This is needed as we are resetting the condition state of each reconcile
but the changing lastTransitionTime field causes reconcile loops.
@openshift-ci openshift-ci bot requested review from olliewalsh and stuggi April 12, 2024 12:22
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gibizer
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmount
Copy link
Contributor

fmount commented Apr 12, 2024

Even with this patch I still see looping in my local test. I'll try a clean environment but I'm not sure it will change the current behavior

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@gibizer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl cd32840 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprince
Copy link
Contributor

dprince commented Apr 12, 2024

@gibizer as discussed yesterday. Here is my PR with all the observedGeneration and savedConditions work: #751

@gibizer
Copy link
Contributor Author

gibizer commented Apr 12, 2024

abandoned in favor of #751

@gibizer gibizer closed this Apr 12, 2024
@gibizer gibizer deleted the control-plane-restore-cond branch July 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants