Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tls] set organization on galera certificate #739

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[tls] set organization on galera certificate #739

merged 1 commit into from
Apr 13, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Apr 9, 2024 •
edited by openshift-ci bot
Loading

From comment on #678 (comment)

The certificate created for galera should populate the 'organization' field, otherwise this trip the SST transfer setup done by wsrep_sst_rsync. This will not show at the initial deployment because there is no SST involved when the DB is bootstrapped as there are no data to be transferred yet.

Jira: OSPRH-2440

@stuggi stuggi requested a review from olliewalsh April 9, 2024 15:12
@openshift-ci openshift-ci bot requested review from abays and dprince April 9, 2024 15:12
@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
@stuggi stuggi requested review from dciabrin and removed request for dprince and abays April 9, 2024 15:12
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/76d79764fd8b4147bd508466d581aa1d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 35s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 3s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3s
❌ openstack-operator-tempest-multinode RETRY_LIMIT in 4s

olliewalsh
olliewalsh reviewed Apr 9, 2024
View reviewed changes
pkg/openstack/galera.go Outdated
// at the initial deployment because there is no SST involved when the DB is bootstrapped
// as there are no data to be transferred yet.
Subject: &certmgrv1.X509Subject{
Organizations: []string{"cluster.local"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was thinking <namespace>.cluster.local for the org in the QEMU certs, probably doesn't matter to much though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it to that. could add a func to the tls certmanager module to return a default org for this?

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/06f9e7e3d4da4b868b56e8047a513739

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 54s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 12m 30s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 13m 14s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 21m 12s

@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/16b4a67c73644dd1b831dfa9d60d3a7d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 37s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 22m 43s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 12m 50s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 24m 27s

@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

recheck

3 similar comments
@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Apr 11, 2024

rebased

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e66374b414604e8898c40caeb0f3099d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 48s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 39s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc MERGE_CONFLICT in 2s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 30m 17s

@stuggi
Copy link
Contributor Author

stuggi commented Apr 11, 2024

recheck

@dciabrin
Copy link
Contributor

/approve
Tested locally with stuggi's help

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dciabrin, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dciabrin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2024
@stuggi
Copy link
Contributor Author

stuggi commented Apr 11, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
[tls] set organization on galera certificate
1ad32e4 
From comment on openstack-k8s-operators#678 (comment)

~~~
The certificate created for galera should populate the 'organization'
field, otherwise this trip the SST transfer setup done by wsrep_sst_rsync.
This will not show at the initial deployment because there is no SST
involved when the DB is bootstrapped as there are no data to be
transferred yet.
~~~

Jira: OSPRH-2440
@openshift-ci openshift-ci bot removed the lgtm label Apr 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

New changes are detected. LGTM label has been removed.

@stuggi
Copy link
Contributor Author

stuggi commented Apr 12, 2024

rebased

@abays abays added the lgtm label Apr 12, 2024
@stuggi
Copy link
Contributor Author

stuggi commented Apr 13, 2024

/test openstack-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit d1a92e5 into openstack-k8s-operators:main Apr 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliewalsh olliewalsh olliewalsh left review comments

@dciabrin dciabrin Awaiting requested review from dciabrin

Assignees

@dciabrin dciabrin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuggi @dciabrin @olliewalsh @abays