Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS custom CA for rabbitmq and nova #728

Conversation

olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Mar 28, 2024

A couple of references to the default internal CA seem to have been missed in #713

Related: OSPRH-5600

@olliewalsh olliewalsh requested a review from stuggi March 28, 2024 16:26
@openshift-ci openshift-ci bot requested review from abays and frenzyfriday March 28, 2024 16:26
@olliewalsh olliewalsh requested review from xek and Deydra71 and removed request for abays and frenzyfriday March 28, 2024 16:26
@olliewalsh
Copy link
Contributor Author

/retest

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xek
Copy link

xek commented Apr 2, 2024

/lgtm Thanks!

@stuggi
Copy link
Contributor

stuggi commented Apr 2, 2024

/test openstack-operator-build-deploy-kuttl

3 similar comments
@stuggi
Copy link
Contributor

stuggi commented Apr 2, 2024

/test openstack-operator-build-deploy-kuttl

@fao89
Copy link
Contributor

fao89 commented Apr 2, 2024

/test openstack-operator-build-deploy-kuttl

@olliewalsh
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit d31f580 into openstack-k8s-operators:main Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants