Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework custom-bundle.Dockerfile to use staged data #525

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Oct 20, 2023

This reworks custom-bundle.Dockerfile so that it involves less stages and can support 2 distinct steps: sync time and build time. This will more cleanly align to our downstream build needs

At sync time a bundle_extra_data directory is populated with ENV variables from all operators (required for webhooks). Additionally dataplane-operator CRDs are cached in this repo.

At build time the custom-bundle.Dockerfile pulls from bundle_extra_data directly.

The csv-merger is used at 'sync time' to extract ENV variables and again at 'build time' to merge those ENV variables along with the dataplane-operators into the combined openstack operator CSV.

Jira: OSP-29916

@openshift-ci openshift-ci bot requested review from abays and viroel October 20, 2023 18:16
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look OK to me. I was able to build the bundles locally with this PR.

hack/bundle-cache-data.sh Show resolved Hide resolved
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good to me

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cfacb5b51ebd4ee7ae7ca2e6ca282438

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 33m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 04m 16s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 8m 37s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7555e7fae42e4a48b53af32875a63523

openstack-k8s-operators-content-provider FAILURE in 11m 53s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@dprince
Copy link
Contributor Author

dprince commented Nov 22, 2023

CI jobs fail to due 'missing skopeo command'. Looking into it

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6ca49142b50445508cb02c67da385fc4

openstack-k8s-operators-content-provider FAILURE in 13m 46s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@dprince
Copy link
Contributor Author

dprince commented Nov 22, 2023

/test openstack-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a4723cf98a244353baa33b540977eeb5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 16s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 33m 07s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 37m 07s

@dprince
Copy link
Contributor Author

dprince commented Nov 27, 2023

Okay, to get the prow jobs passing here I pushed this related PR openshift/release#46095 Once that lands we could set BUNDLE_DOCKERFILE in .prow_ci.env here (in this PR) and use the new location

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c38ce42993784511857626d55ba95a27

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 58s
podified-multinode-edpm-deployment-crc FAILURE in 1h 06m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 58m 05s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 24m 54s

This reworks custom-bundle.Dockerfile so that it involves
less stages and can support 2 distinct steps: sync time and build
time. This will more cleanly align to our downstream build needs

At sync time a bundle_extra_data directory is populated
with ENV variables from all operators (required for webhooks).
Additionally dataplane-operator CRDs are cached in this repo.

At build time the custom-bundle.Dockerfile pulls from bundle_extra_data
directly.

The csv-merger is used at 'sync time' to extract ENV variables
and again at 'build time' to merge those ENV variables along
with the dataplane-operators into the combined openstack
operator CSV.

Jira: OSP-29916
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/34e905adda4d49eb9c17eeab44fbd5db

openstack-k8s-operators-content-provider FAILURE in 12m 17s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@dprince
Copy link
Contributor Author

dprince commented Nov 29, 2023

/test openstack-operator-build-deploy-kuttl

@dprince
Copy link
Contributor Author

dprince commented Nov 30, 2023

recheck

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 1, 2023
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6657a6a into openstack-k8s-operators:main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants