Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv-merger: merge relatedImages #491

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Sep 26, 2023

We need to merge in relatedImages from the dataplane-operator

Also drops the extendedCsv struct as it is no longer needed

@openshift-ci openshift-ci bot requested review from abays and viroel September 26, 2023 00:42
@abays
Copy link
Contributor

abays commented Sep 26, 2023

This seems to pass CI, but it fails to build for me locally:

$ IMAGE_TAG_BASE=quay.io/andrewbays/openstack-operator VERSION=0.0.1 IMG=$IMAGE_TAG_BASE:v$VERSION make manifests build docker-build docker-push bundle bundle-build bundle-push catalog-build catalog-push

...

INFO[0004] Creating bundle.Dockerfile                   
INFO[0004] Creating bundle/metadata/annotations.yaml    
INFO[0004] Bundle metadata generated successfully       
operator-sdk bundle validate ./bundle
ERRO[0000] Error: Value client.openstack.org/v1beta1, Kind=OpenStackClient: CRD "client.openstack.org/v1beta1, Kind=OpenStackClient" is present in bundle "openstack-operator.v0.0.1" but not defined in CSV
...

Might just be something peculiar to my environment.

@dprince
Copy link
Contributor Author

dprince commented Sep 26, 2023

This seems to pass CI, but it fails to build for me locally:

$ IMAGE_TAG_BASE=quay.io/andrewbays/openstack-operator VERSION=0.0.1 IMG=$IMAGE_TAG_BASE:v$VERSION make manifests build docker-build docker-push bundle bundle-build bundle-push catalog-build catalog-push

...

INFO[0004] Creating bundle.Dockerfile                   
INFO[0004] Creating bundle/metadata/annotations.yaml    
INFO[0004] Bundle metadata generated successfully       
operator-sdk bundle validate ./bundle
ERRO[0000] Error: Value client.openstack.org/v1beta1, Kind=OpenStackClient: CRD "client.openstack.org/v1beta1, Kind=OpenStackClient" is present in bundle "openstack-operator.v0.0.1" but not defined in CSV
...

Might just be something peculiar to my environment.

I tried the bundle validate with operator-sdk 1.31 and it seems fine. Is it an older version in your environment? (we don't technically require 1.31 yet but soon will)

@dprince
Copy link
Contributor Author

dprince commented Sep 28, 2023

/test openstack-operator-build-deploy-kuttl

Also drops the extendedCsv struct as it is no longer needed
@dprince
Copy link
Contributor Author

dprince commented Oct 2, 2023

/test openstack-operator-build-deploy-kuttl

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 14a30ca into openstack-k8s-operators:main Oct 2, 2023
3 checks passed
dprince pushed a commit to dprince/openstack-operator that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants