Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EDPM job redefinition with a proper template #462

Merged

Conversation

pablintino
Copy link
Contributor

To avoid redefining jobs that are exact copies of the ci-framework ones we are introducing zuul templates that already define those jobs. This will allow easier maintainability as a change that needs to be applied in the base job and in every child one (ex. var removal, type change, etc.) won't require a change in every repo, just one change in the base one in ci-framework.

To avoid redefining jobs that are exact copies of the ci-framework ones
we are introducing zuul templates that already define those jobs. This
will allow easier maintainability as a change that needs to be applied
in the base job and in every child one (ex. var removal, type change,
etc.) won't require a change in every repo, just one change in the base
one in ci-framework.
@openshift-ci openshift-ci bot requested review from stuggi and viroel September 12, 2023 12:43
@pablintino pablintino requested a review from abays September 12, 2023 12:43
@abays
Copy link
Contributor

abays commented Sep 12, 2023

case.go:366: resource OpenStackControlPlane:openstack-kuttl-tests/openstack-basic: .status.conditions.message: value mismatch, expected: Setup complete != actual: OpenStackControlPlane Nova in progress

/test openstack-operator-build-deploy-kuttl

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2dd4317 into openstack-k8s-operators:main Sep 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants