Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] Provide DatabaseInstance for Octavia if not explicitly set #1233

Open
wants to merge 1 commit into
base: 18.0-fr1
Choose a base branch
from
Open

[18.0-fr1] Provide DatabaseInstance for Octavia if not explicitly set #1233

wants to merge 1 commit into from
+5 −0

Conversation

openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 17, 2024 •
edited by openshift-ci bot
Loading

This is an automated cherry-pick of #1222

/assign gthiemonge

JIRA: OSPRH-12243

@beagles
Provide DatabaseInstance for Octavia if not explicitly set
45615b2 
Several of the operator integrations include a conditional to set a
hardcoded-yet-consistent default DatabaseInstance value if it is not
explicitly set for the component operator. This block was missing from
the Octavia integration.

Jira: OSPRH-12243
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 17, 2024
Merged
@openshift-ci openshift-ci bot requested review from jpodivin and rabi December 17, 2024 08:48
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign jpodivin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weinimo
Copy link
Contributor

weinimo commented Dec 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@weinimo
Copy link
Contributor

weinimo commented Dec 17, 2024

/retest

logger.go:42: 09:39:05 | | Error from server (InternalError): error when creating "https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml": Internal error occurred: failed calling webhook "mnetconfig.kb.io": failed to call webhook: Post "https://infra-operator-controller-manager-service.openstack-operators.svc:443/mutate-network-openstack-org-v1beta1-netconfig?timeout=10s": no endpoints available for service "infra-operator-controller-manager-service" seems unrelated

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 45615b2 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpodivin jpodivin Awaiting requested review from jpodivin

@rabi rabi Awaiting requested review from rabi

Assignees

@weinimo weinimo

@gthiemonge gthiemonge

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @weinimo @gthiemonge @beagles