-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openstack-k8s-operators (main) #1204
Update openstack-k8s-operators (main) #1204
Conversation
/retest |
/retest |
2f16820
to
9b93397
Compare
1f09c9d
to
1bc846c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1bc846c
to
880c5c3
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6d6fec81733e4f6a8c2e39f48e7a3c53 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 46s |
recheck |
/test openstack-operator-build-deploy-kuttl |
/test precommit-check |
880c5c3
to
e7ae6ca
Compare
ℹ Artifact update noticeFile name: apis/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
e7ae6ca
to
a556240
Compare
@vakwetu are the barbican changes ok to be merged? afaik pkcs11 is optional, so it should be fine?
@omersch381 @beagles same for designate?
|
/test openstack-operator-build-deploy-kuttl |
a556240
to
ed2a81f
Compare
designate now has a required RedisServiceName which is required with a default, which seems to be odd https://github.com/openstack-k8s-operators/designate-operator/blob/main/api/v1beta1/designate_types.go#L185 |
ed2a81f
to
c080dc8
Compare
@stuggi yes - the barbican changes are definitely OK to be merged. I made a comment about them in the initial commit. The pkcs11 struct is new and is optional. Its also referenced as a pointer - which will be nil for a barbican undergoing update. |
with openstack-k8s-operators/lib-common#590 , the |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/03e431000b074cbe9830ab8201705454 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 17s |
Lets just drop that condition I think. No need to have it if there is no realistic way you would need it anymore. |
When the dataplane minor update finished, the controller will not set a OpenStackVersionMinorUpdateOVNDataplane after [1]. This change will remove the no longer required check. [1] openstack-k8s-operators/lib-common#590 Signed-off-by: Martin Schuppert <[email protected]>
/test openstack-operator-build-deploy-kuttl |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Get "https://api.oko-12.oooci.ccitredhat.com:6443/api?timeout=32s": dial tcp 38.102.83.63:6443: connect: no route to host |
/test openstack-operator-build-deploy-kuttl |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bd1a1fb3eeaa4fe2ade9b0ea3a567f99 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 23s |
recheck |
/override ci/prow/precommit-check |
1 similar comment
/override ci/prow/precommit-check |
@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openstack-k8s-ci-robot, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/override ci/prow/precommit-check |
@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR contains the following updates:
37d5a9b
->42e8034
9e97663
->9941c12
c06a12f
->7bc56aa
89e9fe9
->d8e6e13
1c476cf
->1491a54
c38568c
->f5fcda7
b225194
->18e54a0
63d25e2
->3faa669
322aab6
->dc78e72
6dc9fd0
->d172b3a
6dc9fd0
->d172b3a
6dc9fd0
->d172b3a
6dc9fd0
->d172b3a
6dc9fd0
->d172b3a
bfd56f1
->110a2db
c6bef3c
->4e7d8f7
591a3bc
->6be30e8
42b7b84
->afc9663
bc64ab6
->ceff33a
3d33d3d
->6f26588
a34ad51
->5d6fb2e
e4c1ba6
->92a44b2
6ab57de
->477944c
f2c8dd9
->ff87fed
20927e1
->b2b1b46
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.