-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test crd schema checker #1202
base: main
Are you sure you want to change the base?
test crd schema checker #1202
Conversation
gibizer
commented
Nov 22, 2024
- [make][pre-commit]Check CRD schema to avoid update issues
- DNM:test make crd-schema-check
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gibizer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7fe2b7c
to
8bb171f
Compare
/hold this is just a test PR to show that the new make crd-schema-check make target included in the pre-commit job catches non backwards compatible CRD changes. |
The pre-commit check should have caught the CRD change but it did not. The make target catches is for me locally so something is with the CI job. |
8bb171f
to
5975d9f
Compare
I see the issue when the pre-commit runs in the CI the proposed commit already placed on the main branch of he repo:
So the schema diff between the proposed commit and main is always empty in CI. I can try to be more specific using origin/main instead of main... |
485c02b
to
d1c2ca3
Compare
The new crd-schema-check make target compares the CRD schema of the patch with the schema on the tip of main and report errors on non backward compatible changes. This make target now also run in pre-commit both locally and in CI. This make target uses https://github.com/openshift/crd-schema-checker to do the actual checking. Related: OSPRH-11833
d1c2ca3
to
ce9cdc7
Compare
@gibizer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |