Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openstackclient] re-create pod when NodeSelector changes #1008

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Aug 16, 2024

When the NodeSelector gets updated via the OpenStackClient NodeSelector api we have to re-create the pod that it gets scheduled for the new configuration

Jira: OSPRH-9443

@openshift-ci openshift-ci bot requested review from fultonj and jpodivin August 16, 2024 13:00
@stuggi stuggi requested review from abays and dprince and removed request for fultonj and jpodivin August 16, 2024 13:00
When the NodeSelector gets updated via the OpenStackClient NodeSelector
api we have to re-create the pod that it gets scheduled for the
new configuration

Jira: OSPRH-9443

Signed-off-by: Martin Schuppert <[email protected]>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 031e12a into openstack-k8s-operators:main Aug 16, 2024
7 checks passed
@stuggi
Copy link
Contributor Author

stuggi commented Sep 3, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@stuggi: new pull request created: #1044

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants