Produce a single archive #70
Merged
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akrog
reviewed
Jul 1, 2024
This patch adds a step at the end of the gathering to produce an additional single archive of the whole gathered content. Use case: I need to grep across pod logs with a request ID so I need to download the content of the gathering. However the content is in a lot of small files causing that a recursive wget takes tens of minutes to finish and probably generates excess load on the log server.
gibizer
force-pushed
the
one-archive
branch
2 times, most recently
from
91686a2 to
f9534a5
Compare
fmount
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
I'm fine with this patch, thank you @gibizer.
I want to make sure someone from the CI team can take a look and approve, but in general looks good to me.
/cc @lewisdenny
* COMPRESSED_PATH env var can be used to define where to store the archive created. By default the archive is stored in the root of the gather directory * DELETE_AFTER_COMPRESSION env var can be used to define whether the uncompressed files are deleted after the compression is done. By default the uncompressed files are also kept. If DELETE_AFTER_COMPRESSION is set to 1 then the files are deleted.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4db8d6b
into
openstack-k8s-operators:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a step at the end of the gathering to produce an
additional single archive of the whole gathered content.
Use case: I need to grep across pod logs with a request ID so I need to
download the content of the gathering. However the content is
in a lot of small files causing that a recursive wget takes tens of
minutes to finish and probably generates excess load on the log server.
archive created. By default the archive is stored in the root of
the gather directory
uncompressed files are deleted after the compression is done. By
default the uncompressed files are also kept. If DELETE_AFTER_COMPRESSION
is set to 1 then the files are deleted.