-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run gather in background #64
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
run_bg can only be used to run executables in the backgorund not bash functions. This change adds a wait_for_bg_slot funciton and refactors the sos report gathering to run in parallel up to the concurrancy limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to have "why" the run_bg
function is not appropriate in the commit message.
I've opened a tracker Jira for this https://issues.redhat.com/browse/OSPRH-7830 |
Thanks @gibizer I think that context is needed in the commit message and the PR description. |
run_bg can only be used to run executables in the backgorund
not bash functions. This change adds a wait_for_bg_slot funciton
and refactors the sos report gathering to run in parallel up to
the concurrancy limit.