-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect all the logs related to openshift-marketplace #48
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Many times certmanager operator installation fails in CI. certmanager-operator comes from openshift-marketplace namespace. os-must-gather does not collects logs related to openshift-marketplace namespace. Capturing the logs from openshift-marketplace will help us to diagnose certmanager operator related issues. Depends-On: openstack-k8s-operators/ci-framework#1554 Signed-off-by: Chandan Kumar <[email protected]>
f15b43d
to
5e45f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, definitely need this one. Saves holding a node to investigate issues.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d7d97f68f99545b89c0a4e068eaa2a6c ❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 17m 26s |
recheck |
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#1554 is needed. |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/dddcdd32d9ea4b4296e555853eab541f ❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 17m 15s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helpful for https://issues.redhat.com/browse/OSPCIX-261
recheck to confirm issue resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment because I'm not 100% sure we should collect this namespace for customers, and we already have a pattern in place to collect additional_namespaces in CI.
@@ -10,6 +10,7 @@ declare -a DEFAULT_NAMESPACES=( | |||
"openshift-machine-api" | |||
"cert-manager" | |||
"openshift-nmstate" | |||
"openshift-marketplace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this should be something that we need to always collect for customers.
If this is a CI only relevant namespace, I suggest to have this line among the ADDITIONAL_NAMESPACES
variable [1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fmount for reviewing it. Sounds good to include it in ci-framework.
I would rather go with: openstack-k8s-operators/ci-framework#1558 |
Closing in favor of openstack-k8s-operators/ci-framework#1558 |
Many times certmanager operator installation fails in CI. certmanager-operator comes from openshift-marketplace namespace.
os-must-gather does not collects logs related to
openshift-marketplace namespace.
Capturing the logs from openshift-marketplace will help us to diagnose certmanager operator related issues.