Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all the logs related to openshift-marketplace #48

Closed

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Apr 24, 2024

Many times certmanager operator installation fails in CI. certmanager-operator comes from openshift-marketplace namespace.

os-must-gather does not collects logs related to
openshift-marketplace namespace.

Capturing the logs from openshift-marketplace will help us to diagnose certmanager operator related issues.

@openshift-ci openshift-ci bot requested review from Akrog and stuggi April 24, 2024 05:02
Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gibizer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Many times certmanager operator installation fails in CI.
certmanager-operator comes from openshift-marketplace
namespace.

os-must-gather does not collects logs related to
openshift-marketplace namespace.

Capturing the logs from openshift-marketplace will help
us to diagnose certmanager operator related issues.

Depends-On: openstack-k8s-operators/ci-framework#1554

Signed-off-by: Chandan Kumar <[email protected]>
@raukadah raukadah force-pushed the redhat-marketplace branch from f15b43d to 5e45f15 Compare April 24, 2024 05:03
Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely need this one. Saves holding a node to investigate issues.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d7d97f68f99545b89c0a4e068eaa2a6c

podified-multinode-edpm-deployment-crc RETRY_LIMIT in 17m 26s

@raukadah
Copy link
Contributor Author

recheck

Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#1554 is needed.

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/dddcdd32d9ea4b4296e555853eab541f

podified-multinode-edpm-deployment-crc RETRY_LIMIT in 17m 15s

Copy link

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raukadah
Copy link
Contributor Author

recheck to confirm issue resolved

@raukadah raukadah requested a review from fmount April 24, 2024 09:58
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment because I'm not 100% sure we should collect this namespace for customers, and we already have a pattern in place to collect additional_namespaces in CI.

@@ -10,6 +10,7 @@ declare -a DEFAULT_NAMESPACES=(
"openshift-machine-api"
"cert-manager"
"openshift-nmstate"
"openshift-marketplace"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this should be something that we need to always collect for customers.
If this is a CI only relevant namespace, I suggest to have this line among the ADDITIONAL_NAMESPACES variable [1]

[1] https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/os_must_gather/defaults/main.yml#L27

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fmount for reviewing it. Sounds good to include it in ci-framework.

@openshift-ci openshift-ci bot removed the lgtm label Apr 24, 2024
@fmount
Copy link
Contributor

fmount commented Apr 24, 2024

I would rather go with: openstack-k8s-operators/ci-framework#1558

@fmount
Copy link
Contributor

fmount commented Apr 24, 2024

Closing in favor of openstack-k8s-operators/ci-framework#1558

@fmount fmount closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants