Improve pre-stop hook to avoid spurious logs #297
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the way the pre-stop hook interacts with the mysql server, to avoid logs showing up in k8s events: . if no mysql socket is available, do no try to connect. . do not stop the server in the pre-hook script, this triggers a failed stop in the k8s events. . do not call the API server to failover the current endpoint, k8s removes the stopping pod automatically, and the remaining galera nodes can elect a new endpoint once the pod is stopping. . do not call mysqladmin when there are no client connections Jira: OSPRH-11392
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dciabrin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the way the pre-stop hook interacts with the mysql server, to avoid logs showing up in k8s events:
. if no mysql socket is available, do no try to connect.
. do not stop the server in the pre-hook script, this triggers a
failed stop in the k8s events.
. do not call the API server to failover the current endpoint, k8s
removes the stopping pod automatically, and the remaining galera
nodes can elect a new endpoint once the pod is stopping.
. do not call mysqladmin when there are no client connections
Jira: OSPRH-11392