when generating metadata.name, use dashes instead of underscores #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Database{} facade that is now used to generate a MariaDBDatabase
as well as a MariaDBAccount is currently generating a metadata
name for the MariaDBAccount based on the username. As we do in
other places, if this username has underscores in it as is common,
swap them out with dashes.
zzzeek
force-pushed
the
escape_underscores
branch
from
637beca to
4943f55
Compare
|
/lgtm |
gibizer
approved these changes
Jan 30, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dciabrin, gibizer, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5ad30f7
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Database{} facade that is now used to generate a MariaDBDatabase as well as a MariaDBAccount is currently generating a metadata name for the MariaDBAccount based on the username. As we do in other places, if this username has underscores in it as is common, swap them out with dashes.